Skip to content
Snippets Groups Projects

Enable flake8 for new python config files (local compilation)

Merged Frank Winklmeier requested to merge fwinkl/athena:flake8_workdir into master

Enable flake8 during local compilation of Accumulator-based python files. Will print a warning for each code violation. See atlasexternals!512 (merged) for further details. Once all packages are clear of warnings, this will be enabled for the full release build as well (see !25435 (merged)).

Packages that want to enable flake8 with the default configuration for all their python modules, can add the following to their CMakeLists.txt:

atlas_install_python_modules( python/*.py
   POST_BUILD_CMD ${ATLAS_FLAKE8} )

Merge request reports

Pipeline #1027205 passed

Pipeline passed for 8c2648c5 on fwinkl:flake8_workdir

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 5 years ago (Aug 8, 2019 6:42pm UTC)

Merge details

  • Changes merged into master with 74f33012.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading