Skip to content

Remove const of MdtDriftCircleOnTrackCreator to remove const_cast of DCMathSegmentMaker and MuonChamberHoleRecoveryTool

Susumu Oda requested to merge oda/athena:master-TRT_CalDbSvc into master

Remove const of MdtDriftCircleOnTrackCreator to remove const_cast of DCMathSegmentMaker and MuonChamberHoleRecoveryTool

http://goetz.web.cern.ch/goetz/mutable_2019-07-13.html#Muon,MuGirl_Mdt

nightly/master/2019-07-13T2149:MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/DCMathSegmentMaker/src/DCMathSegmentMaker.cxx +1795
b48d7d7e459bc13d10c5ae422ccd35db6110ee49	2019-06-10_T1757	Susumu Oda	Add const keyword to fix const-correctness issue of DCMathSegmentMaker.
a36fb5f49a55ff22ba6dca099b790edb5f40ed2d	2019-06-07_T0837	Edward Moyse	Migrated a bunch of Muon tools to be private. For some tools, this is not possible since they contain state. Some configuration changes too to clarify some probable bugs.
249a83d4f3890f6315c726ec4e6e751038384a5e	2019-03-21_T1838	Will Leight	Remove AdjustableT0Tool (Fix for ATLASRECTS-4825)
41a6da32c02a07a79c54c39f6312fae1617737de	2019-02-14_T2329	Will Leight	Fix bug in DCMathSegmentMaker
c2cd9d3ba9a0b40edaf28270b1dc9a3281a24121	2019-02-12_T1030	William Axel Leight	Fixes for muon segment finding

  1793	      (*dcit)=new_dc_on_track;
  1794	
  1795	      MdtDriftCircleOnTrack* dcOn = const_cast<MdtDriftCircleOnTrack*>(constDC);
  1796	      if( hasT0 ) {
  1797		if( msgLvl(MSG::VERBOSE) ){

nightly/master/2019-07-13T2149:MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools/src/MuonChamberHoleRecoveryTool.cxx +1069
e3794aaf1e7e58a114d4f909b42a1cbba1075e5d	2019-04-08_T1031	Will Leight	MuonChamberHoleRecoveryTool should only try to load NSW PRD collections if NSW is being used

  1067		    
  1068		    // cast away constness
  1069		    MdtDriftCircleOnTrack* changeMdtROT = const_cast<MdtDriftCircleOnTrack*>(mdtROT);
  1070		    // sanity check
  1071		    // if( !changeMdtROT ){

RunTier0Tests.py was fine. RunTier0Tests.log

Edited by Susumu Oda

Merge request reports