Skip to content

Fix usage of uninitialised values in TrigL2ElectronFex

Goetz Gaycken requested to merge goetz/athena:master_vg201908_TrigEgammaHypo_declare_correct_member_as_a_property into master

Valgrind reported an issues concerning a conditional jump or move which depends on uninitialised value:

==23584== Conditional jump or move depends on uninitialised value(s)
==23584==    at 0x967E7656: TrigL2ElectronFex::hltExecute(HLT::TriggerElement const*, HLT::TriggerElement*) (in /cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-08-11T2129/Athena/22.0.3/InstallArea/x86_64-centos7-gcc8-opt/lib/libTrigEgammaHypo.so)
==23584==    by 0x4103E0F3: HLT::FexAlgo::plugin_processTE(std::vector<HLT::TriggerElement const*, std::allocator<HLT::TriggerElement const*> >&, HLT::TriggerElement*) (in /cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-08-11T2129/Athena/22.0.3/InstallArea/x86_64-centos7-gcc8-opt/lib/libTrigInterfacesLib.so)
==23584==    by 0x410414E4: HLT::TECombineAlgo::createAndProcessTEs(std::vector<unsigned int, std::allocator<unsigned int> >&, unsigned int, std::vector<HLT::TriggerElement*, std::allocator<HLT::TriggerElement*> >&, std::vector<unsigned int, std::allocator<unsigned int> > const&) (in /cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-08-11T2129/Athena/22.0.3/InstallArea/x86_64-centos7-gcc8-opt/lib/libTrigInterfacesLib.so)
==23584==    by 0x4096C631: HLT::Sequence::execute() (in /cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-08-11T2129/Athena/22.0.3/InstallArea/x86_64-centos7-gcc8-opt/lib/libTrig

This is fixed by declaring a member as a property (rather than declaring a second member twice as a property)

Merge request reports