Skip to content

Avoid R=R.inverse() for Eigen matrices in a couple places in KalmanUpdators

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:kalman_inverse into master

Mentioning @amorley

  • Replace R=R.inverse() either by using R.inverse() in expression or having R_inv=R.inverse() As I think otherwise we might run in Aliasing issue, https://eigen.tuxfamily.org/dox/group__TopicAliasing.html, this depends on the internals.

  • Also try to use a bit more the ATLAS logging macros etc . Note this code has some methods that conditionally execute in verbose / Debug (did not touch the relevant if much)

Merge request reports