Add auto-declaring property constructor to WriteDecorHandleKey

The MultiThreadingEventdataAccess Twiki indicates that WriteDecorHandleKey should have a 4-argument constructor, which automatically declares the WriteDecorHandleKey as a propertyand allows for nice list-initialization (I'd like to use it in the jet reconstruction packages). But, it turns out this constructor doesn't actually exist, which seems to just be an oversight. This MR implements it. The template stuff confused me a bit, so I followed the example of WriteHandleKey.

Tagging @ssnyder and @leggett, who I believe are the authorities on this stuff.

This merge request affects 1 package:

• Control/StoreGate

Adding @ssnyder ,@rbianchi as watchers

added Core master review-pending-level-1 labels

mentioned in merge request !25234 (merged)

Restarted after the planned CI service interruption

Jenkins please retry a build

This merge request affects 1 package:

• Control/StoreGate

Adding @ssnyder ,@rbianchi as watchers

@wbalunas: how about adding a test to test/WriteDecorHandleKey_test.cxx ?

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26025-2019-08-21-05-26
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 2469]

added 1 commit

• 28b6d51c - Add test for new WDHK constructor

Compare with previous version

resolved all discussions

This merge request affects 1 package:

• Control/StoreGate

Adding @ssnyder ,@rbianchi as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26025-2019-08-21-22-50
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 2491]

Could you check why is the CI job is failing now? I am not aware of a CI issue around this time. Please swap the review label back when ready if not done already by the bot.--MR L1

added review-user-action-required label and removed review-pending-level-1 label

There is a compilation problem in StoreGate: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BC7G8AthenaOpt/NICOS_Log_MR-26025-2019-08-21-22-50/Control_StoreGate.html . It appears that it relates to updates in this MR. The CI system works OK.

added 1 commit

• 6883f4a3 - Revert addition of new WDHK test (for now)

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Control/StoreGate

Adding @ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label