Call PunchThroughTools in FastCaloSimSvcV2

Call PunchThroughTools in FCS services to use punch through paramterisation.

Jenkins please retry a build

This merge request affects 2 packages:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added 21.0 Simulation labels

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26173-2019-09-18-16-55
Athena: number of compilation errors 0, warnings 160
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 40699]

added 421 commits

• 6f4e967a...1dffd11d - 418 commits from branch atlas:21.0
• 8a2f1f91 - initial commit
• 9aac6307 - add broker check to SVC, param working
• 22198fdf - now correctly chooses bin

Compare with previous version

added 1 commit

• 74dcc3c0 - remove PunchThroughTool changes

Compare with previous version

Jenkins please retry a build

added 1 commit

• 9bf3fd0f - turn off punch through in config

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

unmarked as a Work In Progress

mentioned in merge request !28580 (merged)

CI Result SUCCESS (hash 74dcc3c0)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41845]

added review-pending-level-1 label

Looks good from the L1 perspective, scaling to L2 review

added review-pending-level-2 label and removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• 58adef65 - using simpler for loop, removed unecessary includes

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers