Added TTree functionality for running over MC

Modifications to DataQuality Z-Counting code for improved analysis on MC.

Moves some histogram booking behind an isSimulation check to prevent explosion of produced histograms.

Creates TTrees for selection and Tag+Probe procedures that are currently only booked when running on MC.

Includes the addition of BCID dependent Histograms

This merge request affects 1 package:

• DataQuality/DataQualityTools

added 21.0 DQ review-pending-level-1 labels

CI Result FAILURE

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26184-2019-08-28-18-57
Athena: number of compilation errors 0, warnings 2
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 40493]

Dear @miokeefe , the test qTestsTier0_required-test failed. Do you know if it is related with your changes?

L1 shifter

Hi @ponyisi

This merge to the DQTGlobalWZFinder is the one with the TTrees (hidden behind an isSimulation check).

Do you know if the failed test here is us?

I can't quite tell from the log file to be honest, have you run the required tests in your private area? At the top of the log file, you can find what is being run here: RunTier0Tests.py -n -e " --maxEvents=20 It seems like there are a ton of warnings connection related, but not sure, had actually problems loading the log file in my browser and searching it.

added review-user-action-required label and removed review-pending-level-1 label

I haven't ran this "RunTier0Tests.py" test, I just ran Reco_tf and everything worked fine there. How exactly should I run this Tier0Tests? I tried just blindly copying what you put above but I don't think it works locally?

Jenkins please retry a build

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-user-action-required label

changed the description

CI Result FAILURE

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26184-2019-09-11-14-58
Athena: number of compilation errors 0, warnings 1
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 40631]

OK, a couple of things - Michael, Harry, could you fix the warnings on this page? They're minor but it would be nice to keep things warning-free: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BS6G62AthenaOpt/NICOS_Log_MR-26184-2019-09-11-14-58/DataQuality_DataQualityTools.html

The test "failure" is a detection of the WARNING pattern that in the MC test the events_lb histogram cannot be retrieved. I agree it's a bit of a silly thing to fail on, but still, should just fix it by not blocking events_lb from being made in MC. We should be able to work around the "explosion" problem by running DQHistogramMerge in Grid jobs.

added review-user-action-required label and removed review-pending-level-1 label

Putting on action-required tag while waiting for the issue to be resolved.--MR L1

added 1 commit

• ea4e626f - Fixed warning messages, removed MC check for m_events_lb histo

Compare with previous version

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26184-2019-09-19-16-25
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 40711]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 3c9345d2 - Tidied up comments from MR

Compare with previous version

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• d680f892 - Removed commented lines

Compare with previous version

This merge request affects 1 package:

• DataQuality/DataQualityTools

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26184-2019-09-24-16-05
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 40764]

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26184-2019-09-24-21-17
Athena: number of compilation errors 0, warnings 159
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 40767]

@tadej or whoever is responsible, would it now be okay to complete the MR? Thanks

resolved all threads

The MR already has seen a lot of discussions and in my quick look over seems to be ok, so approving.--MR L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5b97834e

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• master

mentioned in merge request !27562 (merged)

mentioned in commit f12f375a