FastCaloSim: Migrate AddNoiseCellBuilderTool away from CaloNoiseTool.

Change AddNoiseCellBuilderTool so that instead of using CaloNoiseTool, it uses CaloNoiseCondAlg and CaloEstimatedGainTool. Fixes ToolHandle constness issues.

CaloRec+ISF_FastCaloSimParametrization+FastSimulationJobTransforms+ISF_FastCaloSimServices: Update configuration of AddNoiseCellBuilderTool.

This merge request affects 5 packages:

• Calorimeter/CaloRec
• Simulation/FastShower/FastCaloSim
• Simulation/FastSimulation/FastSimulationJobTransforms
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@pavol ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added Calorimeter JetEtmiss Simulation master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26383-2019-09-06-07-57
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3037]

mentioned in merge request !26396 (merged)

added 1 commit

• f353fc71 - update reference files. increase timeout.

Compare with previous version

This merge request affects 5 packages:

• Calorimeter/CaloRec
• Simulation/FastShower/FastCaloSim
• Simulation/FastSimulation/FastSimulationJobTransforms
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Adding @jchapman ,@pjacka ,@mfauccig ,@pavol ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26383-2019-09-07-01-26
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3057]

Clear, approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 862aca71

added sweep:ignore label

@pavol, @abarton: this MR introduced new warnings, so it should have not been approved/merged.

Hi @fwinkl ,

sorry, you are perfectly right, my fault, will submit fix immediatelly....

 Pavol

mentioned in merge request !26486 (closed)