Skip to content
Snippets Groups Projects

Monopole: Handle fractionally charged particles in 21.0

Merged Wendy Jane Taylor requested to merge wtaylor/athena:21.0-add-fcp-monopole into 21.0

Monopole package Geant4 simulation. Small change to code to check PDGid for fractionally charged particles and extract electric charge from PDGid. Tested the Simulation in 21.0.95 on MadGraph files provided by Quanyin Li. He then tested DigiReco on the simulation output and all was well.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Many CI warnings seem not to be related to this MR.

  • added 1 commit

    • d12c4ec9 - Remove redundant comment/update copyright statement

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/G4Extensions/Monopole

    Adding @jchapman ,@vpascuzz as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-26398-2019-09-09-21-04
    :warning: Athena: number of compilation errors 0, warnings 160
    :warning: AthDataQuality: number of compilation errors 0, warnings 1
    :warning: AthSimulation: number of compilation errors 0, warnings 5
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 40595]

  • Hi @wtaylor . Please can you confirm that you have completed the requests in the discussions? If so, it would be good to resolve them, as this is one indication that the MR is ready to be approved. Thanks in advance. Clara (L1)

  • Wendy Jane Taylor resolved all threads

    resolved all threads

  • Hi @cnellist . Sorry, this is my first time doing a MR. I had posted replies already. Now I clicked the ResolveThread buttons. Is that all that is needed? Thanks! -Wendy

  • Hi @wtaylor. Yep, that's great, thanks! When you resolve the thread, it lets us know that you've implemented the requested changes (or not, as the case may sometimes be) and that there are no outstanding issues. I'll proceed with the review now. Thanks. Clara (L1)

  • Changes look fine to me. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 3d97df68

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading