Monopole: Handle fractionally charged particles in 21.0
Monopole package Geant4 simulation. Small change to code to check PDGid for fractionally charged particles and extract electric charge from PDGid. Tested the Simulation in 21.0.95 on MadGraph files provided by Quanyin Li. He then tested DigiReco on the simulation output and all was well.
Merge request reports
Activity
added 21.0 Simulation review-pending-level-1 labels
CI Result SUCCESSAthena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-26398-2019-09-06-21-34
Athena: number of compilation errors 0, warnings 160
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 40582]- Resolved by Wendy Jane Taylor
- Resolved by Wendy Jane Taylor
added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- d12c4ec9 - Remove redundant comment/update copyright statement
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESSAthena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-26398-2019-09-09-21-04
Athena: number of compilation errors 0, warnings 160
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 40595]Hi @wtaylor . Please can you confirm that you have completed the requests in the discussions? If so, it would be good to resolve them, as this is one indication that the MR is ready to be approved. Thanks in advance. Clara (L1)
Hi @cnellist . Sorry, this is my first time doing a MR. I had posted replies already. Now I clicked the ResolveThread buttons. Is that all that is needed? Thanks! -Wendy
Hi @wtaylor. Yep, that's great, thanks! When you resolve the thread, it lets us know that you've implemented the requested changes (or not, as the case may sometimes be) and that there are no outstanding issues. I'll proceed with the review now. Thanks. Clara (L1)
added review-approved label and removed review-pending-level-1 label
mentioned in commit 3d97df68
added sweep:done label