AthenaPoolCnvSvc: Pass SG key to createPersistent/createTransient.

Rename T_AthenaPoolCustomCnv to T_AthenaPoolCustomCnvWithKey, changing the interfaces for the create methods to pass through the SG key. For compatibility, create T_AthenaPoolCustomCnv deriving from it with the old interfaces.

Update T_AthenaPoolxAODCnv and T_AthenaPoolAuxContainerCnv to use this. In the process, we can remove the xAODCnv hack where we override createObj() in order to get the SG key. (This turns out to be a race; see ATEAM-567.)

A couple other minor cleanups.

This merge request affects 1 package:

• Database/AthenaPOOL/AthenaPoolCnvSvc

Adding @ssnyder ,@mnowak as watchers

added Database master review-pending-level-1 labels

marked as a Work In Progress

changed the description

Some further changes needed in downstream code.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26415-2019-09-08-00-25
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3074]

added 1 commit

• db4789a3 - createTransient -> createTransientWithKey

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• Database/AthenaPOOL/AthenaPoolCnvSvc
• Event/xAOD/xAODTriggerAthenaPool

Adding @ssnyder ,@rbianchi ,@mnowak as watchers

added EDM Trigger labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26415-2019-09-08-13-57
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3081]

Pushing up to L2 due to many changes in this MR. Magdalena (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

All changes seems fine to me, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 22492ee7

added sweep:ignore label