Next step towards new style config of calo-reco

Several fixes/improvements of CaloCellMakerConfig.

To do: Move Calo-flags from AllConfigFlags to dedicated file.

added NewConfig label

added 73 commits

• 8b523ef7...8bf75f61 - 72 commits from branch atlas:master
• 97b1ce78 - Merge branch 'master' into 'CaloNewReco3'

Compare with previous version

This merge request affects 6 packages:

• Calorimeter/CaloCellCorrection
• Calorimeter/CaloRec
• Calorimeter/CaloTools
• Control/AthenaConfiguration
• LArCalorimeter/LArCalibUtils
• LArCalorimeter/LArCellRec

Adding @pavol ,@ssnyder ,@rbianchi as watchers

added Calorimeter Core JetEtmiss LAr master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26441-2019-09-09-19-49
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3101]

The failing unit test (CaloNoiseToolConfig) is actually obsolete. This tool has been migrated to a Conditions Algorithms. I'll delete it ...

• Walter

added 2 commits

• 0fd870fa - remove obsolete CaloNoiseToolConfig.py and all references to it
• ca1c3ac4 - Merge branch 'CaloNewReco3' of https://gitlab.cern.ch:8443/wlampl/athena into CaloNewReco3

Compare with previous version

added 22 commits

• ca1c3ac4...223fa664 - 20 commits from branch atlas:master
• 5650a4dd - move new-style config flags for Calo into separate file
• 41848b6e - merge with local branch containing new CaloConfigFlags file + resolve conficts arising

Compare with previous version

The latest commit moves also calo-related config flags to a dedicated file (see 'to-do' in the description).

• Walter

This merge request affects 10 packages:

• Calorimeter/CaloCellCorrection
• Calorimeter/CaloRec
• Calorimeter/CaloTools
• Control/AthenaConfiguration
• Control/AthenaMonitoring
• InnerDetector/InDetMonitoring/SCT_Monitoring
• LArCalorimeter/LArCalibUtils
• LArCalorimeter/LArCellRec
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigMonitoring/TrigMETMonitoring

Adding @pavol ,@ssnyder ,@rbianchi ,@oda as watchers

added DQ Egamma InnerDetector Trigger labels

added 36 commits

• 41848b6e...f4a4c8c5 - 35 commits from branch atlas:master
• 050d1cc3 - resolve conflict

Compare with previous version

This merge request affects 10 packages:

• Calorimeter/CaloCellCorrection
• Calorimeter/CaloRec
• Calorimeter/CaloTools
• Control/AthenaConfiguration
• Control/AthenaMonitoring
• InnerDetector/InDetMonitoring/SCT_Monitoring
• LArCalorimeter/LArCalibUtils
• LArCalorimeter/LArCellRec
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigMonitoring/TrigMETMonitoring

Adding @pavol ,@ssnyder ,@rbianchi ,@oda as watchers

mentioned in merge request !26469 (merged)

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26441-2019-09-10-17-23
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3133]

Changes look good to me, but I'd like to ask L2 to double check.--MR L1

added review-pending-level-2 label and removed review-pending-level-1 label

Seems fine to me as well, approving.

Not sure, why pipeline is showed failed, when CI are fine for this MR.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

Superseeded by !26469 (merged). Closing.

closed