More cell correction tools in new-style config
With this MR, the reconstructed LAr-Cell quantities are identical in the q431 25-events sample comparing old and new configuration. I still see differences for Tile cells though. (@harkusha ?)
The LArDeadOTx correction tool is also missing but this has no visible impact for data like the q431 input w/o any dead LAr electronics. This one is a bit tricky because it depends on a lot of trigger stuff.
Note that the changeset of this MR contains MR !26441 (closed)
Merge request reports
Activity
added NewConfig label
added 44 commits
-
1e10aeec...9a83f87c - 43 commits from branch
atlas:master
- 2b8ad7cc - resolve comflict (rm CaloNoiseToolConfig.py)
-
1e10aeec...9a83f87c - 43 commits from branch
This merge request affects 10 packages:
- Calorimeter/CaloCellCorrection
- Calorimeter/CaloRec
- Calorimeter/CaloTools
- Control/AthenaConfiguration
- Control/AthenaMonitoring
- InnerDetector/InDetMonitoring/SCT_Monitoring
- LArCalorimeter/LArCalibUtils
- LArCalorimeter/LArCellRec
- Trigger/TrigMonitoring/TrigEgammaMonitoring
- Trigger/TrigMonitoring/TrigMETMonitoring
added Calorimeter Core DQ Egamma InnerDetector JetEtmiss LAr Trigger master review-pending-level-1 labels
- Resolved by Siarhei Harkusha
Hi @wlampl,
Wrong Tile reconstruction method is used when input data type is BS in new style configuration.
This method is auto configured using the following flag:ConfigFlags.Beam.Type
But this flag in the case of BS is
Beam.Type : [1]
and in the case of POOL it is
Beam.Type : 'collisions'
Is it supposed to be so?
According to the following link in the case of BS beam type should be transformed into string from number:
https://gitlab.cern.ch/atlas/athena/blob/master/Tools/FilePeeker/src/BSFilePeeker.cxx#L75
So, as temporary workaround one can fix the tests by using/forcing the following flag:
ConfigFlags.Beam.Type = 'collisions'
Or maybe it worth to modify auto configuration of the flag
ConfigFlags.Beam.Type
to return always string instead of number in both cases?
What do you think?
Tagging @solodkov also.
Cheers,
Siarhei
CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-26469-2019-09-10-23-04
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3152]added review-approved label and removed review-pending-level-1 label
mentioned in commit 7f283f78
added sweep:ignore label
mentioned in merge request !26441 (closed)