Skip to content
Snippets Groups Projects

Update frozen shower generation scripts and code to be compatible with recent developments

Closed Update frozen shower generation scripts and code to be compatible with recent developments
SG-frozenShowersGeneration-23-Sept_2019 into master
3 unresolved threads
Closed Alexander Glazov requested to merge SG-frozenShowersGeneration-23-Sept_2019 into master
3 unresolved threads

Merge request reports

Pipeline #1109834 failed

Stage: external

    Pipeline failed for a69e4d97 on SG-frozenShowersGeneration-23-Sept_2019

    Closed by Alexander GlazovAlexander Glazov 5 years ago (Sep 26, 2019 8:35am UTC)

    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    LArCalorimeter/LArG4/LArG4GenShowerLib/share/LArG4GenerateShowerLib.py
    43 43 from G4AtlasApps.SimFlags import simFlags
    44 44 simFlags.load_atlas_flags()
    45 45 simFlags.CalibrationRun.set_Off()
    46 simFlags.EventFilter.set_off()
    46
    47 # simFlags.EventFilter.set_off()
  • Magdalena Slawinska @maslawin started a thread on the diff
    • LArCalorimeter/LArG4/LArG4FastSimulation/src/LArFastShower.cxx
    1 1 /*
    2 2 Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
  • Magdalena Slawinska added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • M
    Magdalena Slawinska @maslawin ·
    Developer

    Please fix the above and then relabel. Magdalena (L1)

  • John Derek Chapman
    John Derek Chapman @jchapman started a thread on an old version of the diff
    • LArCalorimeter/LArG4/LArG4GenShowerLib/share/LArG4GenerateShowerLib.py
    71 72 # get service manager
    72 73 from AthenaCommon.AppMgr import ServiceMgr
    73 74
    74 include("G4AtlasApps/G4Atlas.flat.configuration.py")
    75
    76 75 ## Populate alg sequence
    76 from G4AtlasApps.PyG4Atlas import PyG4AtlasAlg
  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Any particular reason that this merge request is going into 21.9 (which is for phase II upgrade developments)? Simulation developments for Run-3 not connected to Fast Chain or NSW, should go directly into master.

  • Alexander Glazov changed target branch from 21.9 to master

    changed target branch from 21.9 to master

  • Alexander Glazov closed

    closed

    • Please register or sign in to reply