ATR-20158 - fix BLS slice chains

Closes ATR-20158

--> add check if combined muon before checking if track link is valid --> was just fluke that this didn't come up before

ctests, art tests have all passed (menu test timed out with default time settings, but passes if this is increased)

thanks to @sshaw for reminding me how muon chains work!

cheers, Heather

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigBphysHypo

added Trigger master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26764-2019-09-24-02-37
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3530]

Hi, it looks like the failure is just an outdated reference?

< 0TriggerSummaryStep4:Start INFO Time User : Tot= 0 [us] #= 1@0 5022 5447@10 jetalg_HLT_AntiKt10LCTopoJets_subjes

nothing to do with this MR...

cheers, Heather

The reference seems fine and this problem comes from an unfortunate mangling of outputs from ChronoStatSvc and PerfMonSvc. This is a problem only when the mangled lines happen to be matching the reference regex, which is actually quite rare. It's only second time I see this over a few months. Rerunning the CI should help here. Tagging @amete who was investigating this interference between ChronoStatSvc and PerfMonSvc.

Cheers,
Rafal

Jenkins please retry a build

Also tagging @hartj and @jpanduro for information

Hi @rbielski,

I circumvented this problem by disabling the table printing from ChronoStatSvc and removing the related auditors for the MT trigger SPOT test using a preExec:

--postExec='all:svcMgr.AuditorSvc.Auditors.remove("ChronoAuditor/ChronoAuditor");svcMgr.ChronoStatSvc.ChronoPrintOutTable=False;svcMgr.ChronoStatSvc.StatPrintOutTable=False;svcMgr.ChronoStatSvc.PrintUserTime=False;'

Not nice but you can perhaps use this until a more appropriate solution is found.

Best, Serhan

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigBphysHypo

Thanks @amete for the suggested workaround. I'll look into adding this into our job options until we have a better solution.

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26764-2019-09-24-14-53
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3543]

mentioned in merge request !26753 (closed)

added urgent label

Hi,

who are the level-1 shifters? Can someone review this please?

It fixes many of the broken nightly tests.

Thanks! Heather

You can see shifters here: https://atlasop.cern.ch/otp/SCList.php (not a great page - takes a while to load and you may need to try twice)

changed the description

added review-approved label and removed review-pending-level-1 label

I'm the shifter this afternoon. I'm sorry I missed that this is urgent and was going by last update order. Approved.--MR L1

Thanks @maxcw! I only added urgent at around noon :)

merged

mentioned in commit eb634acc

added sweep:ignore label

mentioned in merge request !27120 (merged)