Skip to content
Snippets Groups Projects

Add menu writing at initialize to L1 and HLT configuration service

Merged Joerg Stelzer requested to merge stelzer/athena:master-MenuProvider into master

Writes L1Menu and HLTMenu to the detector store during initialize(). Clients of the trigger menus should retrieve them from there in start() or later.

Also fix the problem with the CTPSimulation, reported in ATR-20331

@tbold @fwinkl @mark @hrussell

Merge request reports

Pipeline #1116267 passed

Pipeline passed for d8bbdad1 on stelzer:master-MenuProvider

Approval is optional

Merged by Walter LamplWalter Lampl 5 years ago (Sep 26, 2019 3:30pm UTC)

Merge details

  • Changes merged into 21.0 with 6330cd04.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold
  • Tomasz Bold approved this merge request

    approved this merge request

  • :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-26787-2019-09-25-18-04
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3572]

  • Joerg Stelzer added 1 commit

    added 1 commit

    • d8bbdad1 - Fix TriggerJobOpts flake unit test

    Compare with previous version

  • Joerg Stelzer resolved all threads

    resolved all threads

  • Joerg Stelzer resolved all threads

    resolved all threads

  • This merge request affects 5 packages:

    • Reconstruction/RecJobTransforms
    • Trigger/TrigConfiguration/TrigConfigSvc
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigValidation/TrigUpgradeTest
    • Trigger/TriggerCommon/TriggerJobOpts

    Adding @hartj ,@jpanduro ,@mark as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-26787-2019-09-26-14-40
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3596]

  • Looks ok to me. Approved.--L1

  • Bringing attention to release coords. This MR enables quite some front of work.

  • added urgent label

  • Tagging @wlampl explicitly as he is current release coordinator.

  • merged

  • Walter Lampl mentioned in commit 6330cd04

    mentioned in commit 6330cd04

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading