Legacy trigger IDC cachefix ATR-20355

Attempt to solve the problems in ATR-20355. I previously cleared the IDC new event clearing (in !26692 (merged)) because I thought they were created fresh every event, but this is not the case in legacy trigger software.

I also clean up some const_cast and const correctness.

cc @tbold

added bugfix label

This merge request affects 3 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Adding @kzoch ,@ibragimo as watchers

added InnerDetector master review-pending-level-1 labels

added 1 commit

• 6a20fd75 - Add error checking

Compare with previous version

added 1 commit

• ef2cf53a - Add error checking

Compare with previous version

This merge request affects 3 packages:

• InnerDetector/InDetEventCnv/BCM_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv

Adding @kzoch ,@ibragimo as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26836-2019-09-27-20-08
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3626]

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-26836-2019-09-27-21-07
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 3629]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c2a6c26d

added sweep:ignore label