Skip to content
Snippets Groups Projects

setting bad status for fragments if ROB is completely missing in ByteStream

Merged Sanya Solodkov requested to merge solodkov/athena:tilecal-for-22.0 into master
All threads resolved!

Set bad status in TileRawChannelCollection if ROB fragment is completely missing in ByteStream

It's manual sweep from 21.0 because automatic sweep failed, see !27162 (merged)

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 5 years ago (Oct 24, 2019 11:12am UTC)

Merge details

  • Changes merged into master with 3f3aa6e8 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Please remember to swap the review tag back for review.--L1

  • Sanya Solodkov added 1 commit

    added 1 commit

    • 7dca7e7b - change std::map to std::unordered_map

    Compare with previous version

  • Sanya Solodkov resolved all threads

    resolved all threads

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 148K in file TileCalorimeter/TileSvc/TileByteStream/share/TileLaserObjByteStreamCnv_test.ref

    :pencil: 148K in file TileCalorimeter/TileSvc/TileByteStream/share/TileMuRcvContByteStreamCnv_test.ref

  • This merge request affects 1 package:

    • TileCalorimeter/TileSvc/TileByteStream

    Adding @pavol ,@solodkov ,@harkusha as watchers

  • Author Developer

    Jenkins please retry a build

  • :white_check_mark: CI Result SUCCESS (hash 7dca7e7b)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 4659]

  • Looks good for me. Approved.--L1

  • mentioned in commit 3f3aa6e8

  • Sanya Solodkov mentioned in merge request !27162 (merged)

    mentioned in merge request !27162 (merged)

  • Please register or sign in to reply
    Loading