ZCounting Truth Matching functions

Added functions for truth matching tracks, muons, electrons. Only runs on MC. MCTruthClassifier needed in the CMakeList

added 21.0 DQ labels

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label

added 1 commit

• 98f41ea1 - ZCounting Truth Matching standard cpp variable types

Compare with previous version

Sorry, Ignore first commit if possible. Wasn't supposed to change the variable types in the .h file

This merge request affects 1 package:

• DataQuality/DataQualityTools

CI Result SUCCESS (hash eefcd2f7)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 160
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 41116]

CI Result SUCCESS (hash 98f41ea1)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41120]

added review-pending-level-2 label and removed review-pending-level-1 label

Asking L2 to help look at the change in DQTGlobalWZFinderTool.cxx.--L1

resolved all threads

Hi @halyons - this MR seems to add functionality, but then not use it, in some places. Is this still a bit work-in-progress in places?

Could you tidy up the commented out code too.

Thanks - Tim (L2)

added review-user-action-required label and removed review-pending-level-2 label

Hi @halyons,

Could you also please add ATLAS Robot as developer to your fork? (https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot)

Thanks, Tadej (L1)

added 2 commits

• 444b95ed - Cleanup+Comments of Truth Functions
• 487767a3 - Whitespace and Comment cleanup

Compare with previous version

Hi @tamartin

Sorry on the delay, I've added some descriptive comments The new functions are being called, but only on MC (hidden behind a isSimulation check)