Removing additional photons from light mesons in Truth3 collection

The original cut on photons within TRUTH3 was that they not be identified as coming from a pi0 and that they be at least 20 GeV. This leaves a large number of photons in simple samples that are identified as having come from a light meson and are quite low momentum. We shouldn't need those either (etas and rhos are not interesting), so this MR modifies the collection requirements to look particularly for those not from light mesons either.

This saves us about 0.35 kB/event, or about 10% of the total file size, and takes the photon containers down from about 0.6 to 0.25 kB/event. After this, it's no longer so dominant.

FYI: @jcatmore , @lcorpe , @ewelina

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth

added 21.2 Derivation review-pending-level-1 labels

added changes-derivation-output label and removed 21.2 review-pending-level-1 labels

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash c7ab3688)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41213]

Yep, output is exactly as expected (these extra truth photons are missing). That's the optional test failure. Presumably this will require updating a reference file. I'm happy to help if somebody tells me what would be needed.

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash c7ab3688)

	AnalysisBase	AnalysisTop	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 4952]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash c7ab3688)

	AnalysisBase	AnalysisTop	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 4959]

Hmmm... this doesn't seem to have gotten any automatic labels... Setting them...

added review-pending-level-1 label

added 21.2 label

Hi @zmarshal,

What happened is that you set the changes-derivation-output label at the same time as the CI tried to set its own labels. Whenever two sides try to update the labels at the same time only one of them takes effect (removing the labels the other side set). It's best either to set the label as part of defining the MR, or to wait until the CI has set its labels.

Regards, Nils

looks fine to me.

added review-approved label and removed review-pending-level-1 label

@egramsta, @guirriec, @boeriu: This is only affecting derivations.

merged

mentioned in commit 67889d60

added sweep:ignore label