Add di-tau to DAOD_PHYS

Hello,

This MR adds the low-pt and high-pt di-tau objects to DAOD_PHYS (ATLASG-1502). High-pt di-taus are already part of the standard reconstruction, while low-pt di-tau reconstruction needs to be scheduled explicitly in R21 (it has been added to TauCommon). We have added smart slimming lists for low- and high-pt di-taus which include all Aux variables at the moment, to be refined soon. The DAOD_PHYS structure had to be slightly reshuffled, because the low-pt ditau reconstruction relies on AntiKt2PV0TrackJets, so the the "Jet/MET" block needs to be scheduled before the low-pt di-tau reconstruction and track thinning.

Cheers, Bertrand

Output size (from MC ART tests) with di-tau:

================================================================================
         Categorized data
================================================================================
     Disk Size         Fraction    Category Name
--------------------------------------------------------------------------------
       1.581 kb        0.040       tau
       2.793 kb        0.071       InDet
      39.243 kb        1.000       Total

and prior to this MR:

================================================================================
     Disk Size         Fraction    Category Name
--------------------------------------------------------------------------------
       1.238 kb        0.033       tau
       2.070 kb        0.054       InDet
      38.087 kb        1.000       Total

added 21.2 Derivation Tau labels

Tagging @ntamir , @dkirchme , @lfiorini , @mojeda , @cgrefe for information.

This merge request affects 3 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkExamples
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau

added review-pending-level-1 label

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash bc7574f6)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41272]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash bc7574f6)

	AnalysisBase	AnalysisTop	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 5135]

added 1 commit

• 1390da52 - refine smart slimming for ditau, and require 2 subjets for low pt ditaus

Compare with previous version

This merge request affects 3 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkExamples
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau

changed the description

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 1390da52)

	AnalysisBase	AnalysisTop	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 5176]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 1390da52)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41278]

added urgent label

Hello, I have added the 'urgent' label, my understanding is that the DAOD_PHYS production is imminent. Thanks!

added review-approved label and removed review-pending-level-1 label

@egramsta, @guirriec, @boeriu: This is only affecting derivations.

The changes to DerivationFrameworkExamples/share/PHYS.py and DerivationFrameworkTau/python/TauCommon.py need more extensive review, escalating to L2. --L1

added review-pending-level-2 label and removed review-approved label

Hi @etolley,

I had taken a look at the changes and they seemed fine to me. Though if you want one more set of eyes on this we can wait on L2.

Regards, Nils

The changes look good, marking as approved.

-Jennifer (L2)

added review-approved label and removed review-pending-level-2 label

mentioned in commit 7fb014af

merged

added sweep:ignore label

Hi @martindl,

Some ART tests are failing,e.g. https://bigpanda.cern.ch//media/filebrowser/0232cd87-4df1-462f-87e0-94bd41000048/user.artprod/tarball_PandaJob_4536032143_ANALY_LPSC_CL7/log.AODtoDAOD

Could you please have a look?

Thanks, Oana

Hi @boeriu ,

Thanks. In this case, the error seems to be

04:42:58 Py:DerivationFramework__SlimmingHelper   ERROR Using AllVariables for a container with a smart slimming list (DiTauJets) is not permitted for the format HIGG4D2 - please use smart slimming and/or ExtraVariables

Now that we have a smart slimming list for ditau, maybe it has become explicitly forbidden to use AllVariables for some formats which are "blacklisted" here: https://gitlab.cern.ch/atlas/athena/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/AllVariablesDisallowed.py

I will have a look.

Cheers, Bertrand

mentioned in merge request !27769 (merged)

Here is the follow-up MR: !27769 (merged)

mentioned in commit 786d6441