Skip to content
Snippets Groups Projects

Use di-tau smart slimming instead of AllVariables

All threads resolved!

Hello,

As reported in !27694 (merged) , the introduction of a smart slimming list for DiTauJets and DiTauJetsLowPt collections has caused trouble for DAOD formats using AllVariables for these collections. The use of AllVariables is not allowed for large formats. The smart collections have to be used instead. As far as I can see, only DFHiggs needs that change. TAUP5 still uses AllVariables for DiTauJetsLowPt, but it's a small CP format which is not subject to the AllVariables restriction. I am running ART tests with the fix for HDBS1 and HIGG4D2, it seems fine.

Cheers, Bertrand

Merge request reports

Pipeline #1205371 passed

Pipeline passed for 98781fc5 on martindl:21.2_DF_DitauSmartListFix

Approval is optional

Merged by Oana Vickey BoeriuOana Vickey Boeriu 5 years ago (Nov 6, 2019 4:29pm UTC)

Merge details

  • Changes merged into 22.0 with e0af86ce (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I just have a minor comment to the code. Magdalena (L1)

  • resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs

    Adding @oda as watcher

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 98781fc5)

    AnalysisBase AnalysisTop AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisTop: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 5287]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 98781fc5)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 41322]

  • assigned to @ntamir

  • unassigned @ntamir

  • looks fine to me.

    @egramsta, @guirriec, @boeriu: This is only affecting derivations.

  • mentioned in commit e0af86ce

  • Please register or sign in to reply
    Loading