Skip to content

FakeBkgTools flexibility improvements

Julien Maurer requested to merge (removed):b21_2-FakeBkgTools-Nov08 into 21.2

A couple small changes to the FakeBkgTools package and its tool interface (in the AsgAnalysisInterfaces package), related to two bug fixes and a couple improvements to allow more flexibility:

  • commit b2078368: fixed bug in Database.cxx affecting the parsing of negative values for bin boundaries read from XML files. There should be no impact on past results as the tools would simply refuse to initialise in these situations.

  • commit ae6d15f3: fixed bug in Database.cxx preventing the proper reading of -inf bin boundaries (minus sign overlooked) in XML files. Again, no impact on past results, for the same reason.

  • commit 2e8efc80: removed definition of the FAKEBKGTOOLS_ATLAS_ENVIRONMENT macro in the interface (IFakeBkgTool.h) since Attila did it in a cleaner way (in CMakeLists.txt) in commit cb709c60. Sorry for the delay.

  • commit 298089fb: added support for reading the input efficiencies from TH3 histograms as well (in addition to TH1 and TH2), as this was requested by several users on the tools mailing list. Support of THn histograms is postponed as this would require a bit more involved changes.

  • commit 479d2413: in the context of the discussion in !27784 (closed), added basic support for xAOD::TauJet (including reading efficiencies for taus from ROOT/XML inputs) in the hypothetical case that the developers decide to rely on the FakeBkgTools package. The modifications are trivial (copy-paste of similar code for electrons and muons).

cc @evarnes

Edited by Julien Maurer

Merge request reports