Update of the NSW cluster builders

Updating all cluster builder tools to write out properties of the elements in the cluster according to this MR: !28029 (merged)

uTPC:

• better determination of the drift uncertainty for the strips
• introducing a cut to deal with cross talk
• introducing linear fitter to estimate fit parameters for the final fit

added alsoTargeting:21.9 + 1 deleted label

added 1 commit

• 30effba2 - adding constructor for sTGC

Compare with previous version

added 1 commit

• f25ee6e2 - fixing types

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added 21.3 MuonSpectrometer review-pending-level-1 labels

CI Result SUCCESS (hash f25ee6e2)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 13
For experts only: Jenkins output [CI-MERGE-REQUEST 41528]

Looks good to me, only please remove some leftover commented code, scaling to L2 since quite non-trivial changes. Edson (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added 1 commit

• 257b5eaa - removing commented code

Compare with previous version

resolved all threads

Hi, I have addressed the request of @carquin by removing the commented code. Furthermore I have addressed the one compilation warning introduced by this MR. The other ones are unrelated to this MR Cheers, Patrick

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

CI Result SUCCESS (hash 257b5eaa)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41539]

added 1 commit

• b0a4a2da - introducing cut on the max number of strips cut by the crosstalk cut

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

CI Result SUCCESS (hash b0a4a2da)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41554]

added 1 commit

• 256f2ac1 - bugfix for nStripsCut=0

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

CI Result SUCCESS (hash 256f2ac1)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 12
For experts only: Jenkins output [CI-MERGE-REQUEST 41562]

Looks good, scaling to L2 --L1

added review-pending-level-2 label

removed review-pending-level-1 label

Nothing further from me - Tim (L2)

added review-approved label and removed review-pending-level-2 label

mentioned in commit 50d0277a

merged

added sweep:done label

mentioned in commit 2613c8f4

mentioned in merge request !28200 (closed)

added sweep:failed label

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/975/console for details)failed:

• 21.9

MR to master closed due to changes in the id helpers. I will do the merge to master by hand and open a new MR.

mentioned in merge request !28220 (merged)

Manuel sweep to master: !28220 (merged)

removed sweep:failed label

Thanks @pscholer - dropping sweep:failed label.

mentioned in merge request !28288 (merged)

Hi @jchapman, the sweep failed was actually introduced by the sweep to 21.9, not by the one to master. Anyhow, you can find the manual sweep to 21.9 here: !28288 (merged) . So the removal of the sweep:failed is fine now :) Cheers, Patrick

Thanks @pscholer!

mentioned in merge request !28706 (merged)

mentioned in commit aca03460