Bug fix for incorrect BCID from L1MUEndcap to MuCTPI in MC for 21.X (ATR-20569)
The bug only in MC causes L1MuonEndcap (TrigT1TGC package) was always sending current bunch ID (0 for MC) to MuCTPI, even when detector hits and the candidate decision is calculated for the different bunches. Since Run-2 upgrade, L1MU simulation takes into account the timing and bunch crossing identification for L1Topo LateMuon trigger. Although TGC digitization and TrigT1TGC calculates properly, but sending always fixed number to MUCTPI (0). The bug caused zero count of L1_LATE-MU10_XX in the endcap region (i.e. the current counts is coming from barrel only.)
The compilation, the test script test_mc_pp_v7_build.sh
and private MC tests are fine.
The merge request for master (22.x) branch is done here. Please sweep this MR to only 21.X.
Merge request reports
Activity
added Trigger review-pending-level-1 labels
CI Result SUCCESS (hash e9333779)Athena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41594]added review-approved label and removed review-pending-level-1 label
added sweep:ignore label
mentioned in commit 2bd8e2c1
Dear @junpei,
It seems this MR has broken the q440 TCT (https://bigpanda.cern.ch/art/jobs/?package=Tier0ChainTests&branch=21.0/Athena/x86_64-slc6-gcc62-opt&ntag_full=2019-11-26T2152&view=packages).
See here for the log with the error: https://bigpanda.cern.ch//media/filebrowser/fca60fe4-9eef-46da-9ae3-771f6edc7f71/user.artprod/tarball_PandaJob_4561024779_ANALY_CERN_T0_ART/payload.stdout
The differences are in the
myESD.pool.root
files. There is one leaf that differs:003.MuCTPI_RDO_p1_MUCTPI_RDO.m_dataWord.1 244848450L -> 244864834L => diff= [-0.00167282%]
If I revert this MR locally and re-run the test, the error disappears, so I am suspecting that the differences are coming from your changes.
Could you take a look and see if this is really the case and if you can fix it?
In the meantime, I'll revert this MR to hopefully have the test run successfully for the next nightly.
Best, Ruth
mentioned in commit a48ce8ab
mentioned in merge request !28342 (closed)
Dear @pottgen,
My commit should have differences in MuCTPI_RDO, since I fixed a bug of data sent from Endcap L1Muon to MuCTPI. So this difference is expected.
Thanks, Junpei
Dear @junpei,
Ok, thanks for confirming that this is expected. (In the future, it would be good if expected differences could be flagged in advance, e.g. when making the MR, so that I don't cause so much confusion.)
I will close the MR (!28342 (closed)) that would revert this one.
Best, Ruth
mentioned in merge request !28989 (merged)
mentioned in commit 1e705b32
mentioned in merge request !39433 (merged)
mentioned in merge request !39463 (merged)