Skip to content
Snippets Groups Projects

Cleanups of (I)SCTRawDataProviderTool.h

Merged Susumu Oda requested to merge oda/athena:master-slotspecificobj into master

Cleanups of (I)SCTRawDataProviderTool.h

  • Remove unnecessary includes
  • Make ISCTRawDataProviderTool of TrigSCTRawDataProvider private
Edited by Susumu Oda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Susumu Oda added 1 commit

    added 1 commit

    • aeeee608 - Remove unnecessary includes. Make ISCTRawDataProviderTool of TrigSCTRawDataProvider private

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv
    • InnerDetector/InDetTrigRecAlgs/InDetTrigRawDataProvider

    Adding @goetz ,@oda ,@sroe as watchers

  • added Trigger label

  • Susumu Oda resolved all threads

    resolved all threads

  • Susumu Oda changed title from Remove unnecessary include of AthenaKernel/SlotSpecificObj.h to Cleanups of (I)SCTRawDataProviderTool.h

    changed title from Remove unnecessary include of AthenaKernel/SlotSpecificObj.h to Cleanups of (I)SCTRawDataProviderTool.h

  • Susumu Oda changed the description

    changed the description

  • :white_check_mark: CI Result SUCCESS (hash d2966d31)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6049]

  • :white_check_mark: CI Result SUCCESS (hash aeeee608)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6051]

  • Looks good, and changes are quite minor, approving --L1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading