Skip to content
Snippets Groups Projects

Add _p4 version of CscRawDataCnv

Merged Add _p4 version of CscRawDataCnv
nkoehler/athena:cscCnv16d into 21.0-mc16d
Merged Nicolas Koehler requested to merge nkoehler/athena:cscCnv16d into 21.0-mc16d

Hi,

this MR is a manual sweep of the 3 MRs !28146 (merged), !28231 (merged) and !28290 (merged) into 21.0-mc16d.

It adds a CscRawDataCnv_p4 converter since we moved from using CSC identifier hashes which reflect the geometrical position of the CSCs to the actual index of the identifier in the vector of identifiers (positional hash) in !24467 (merged) in master.

For the 21.0 releases, we want to keep the old geometrical channel identifier hashes as baseline in the transient format. Thus only the _p4 version of the converters translates positional identifier hashes from the persistent p4 files back to geometrical channel identifier hashes needed by the 21.0 transient model. There is also a transToPers() implementation for p4 which however is not the default for 21.0.

The content of the CscRawData still stays as in version p3, just the meaning of m_hashId changes from geometrical to positional hash.

Adding @mnowak, @jchapman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Koehler added sweep:ignore label

    added sweep:ignore label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonCnv/MuonEventAthenaPool
    • MuonSpectrometer/MuonIdHelpers

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added 21.0-mc16d MuonSpectrometer review-pending-level-1 labels

    added 21.0-mc16d MuonSpectrometer review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 4c9b3e79)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    required tests :white_check_mark:
    optional tests N/A

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 171
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 41678]

  • Ana Maria Rodriguez Vera
    Ana Maria Rodriguez Vera @anmrodri ·
    Developer

    Hi @nkoehler,

    Could you take a look at the following errors?

    Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_innerMBTS"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_special"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsLB"
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
Error in <TFile::TFile>: file data17_13TeV.00337491.express_express.merge.HIST.f873_h263.root does not exist
Cannot find "run_337491" in file
# CMake ---> /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.11.0/Linux-x86_64/bin/cmake -E copy /build2/ci-builds/21.0-mc16d/Athena/build/Athena/DataQuality/DataQualityConfigurations/CMakeFiles/heavyions_minutes10.hcfg /build2/ci-builds/21.0-mc16d/Athena/build/Athena/x86_64-slc6-gcc62-opt/data/DataQualityConfigurations/heavyions_minutes10.hcfg
# CMake ---> /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.11.0/Linux-x86_64/bin/cmake -E copy /build2/ci-builds/21.0-mc16d/Athena/build/Athena/DataQuality/DataQualityConfigurations/CMakeFiles/collisions_minutes10.hcfg /build2/ci-builds/21.0-mc16d/Athena/build/Athena/x86_64-slc6-gcc62-opt/data/DataQualityConfigurations/collisions_minutes10.hcfg
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_innerMBTS"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_special"
Error in <TFile::TFile>: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist
HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsLB"

    Regards, Ana M. (L1)

  • Ana Maria Rodriguez Vera added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Nicolas Koehler
    Nicolas Koehler @nkoehler ·
    Author

    Hi @anmrodri,

    where did you observe these error messages?

    Thanks, Nico

  • Nicolas Koehler added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • M
    Magdalena Slawinska @maslawin ·
    Developer

    Hi, from what I see here: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/ci/CIWebArea/nicos_web_areaMRCIbuilds64BS6G62AthenaOpt/NICOS_Log_MR-28302-2019-11-27-03-44/DataQuality_DataQualityConfigurations.html#prblm

    the problems listed above are due to missing reference files that are not relevant for this MR:

    CMake ---> ../../atlas_build_run.sh han-config-gen /build2/ci-builds/21.0-mc16d/Athena/build/Athena/DataQuality/DataQualityConfigurations/CMakeFiles/collisions_run.config

    Error in TFile::TFile: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB" Error in TFile::TFile: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_innerMBTS" Error in TFile::TFile: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsEB_special" Error in TFile::TFile: file /afs/cern.ch/user/a/atlasdqm/dqmdisk/tier0/han_references/Collisions/TileDigiErrorsReferences_20170814.root does not exist HanConfig::RefVisitor::Visit(): Reference not found: "TileDigiErrorsLB"

  • Magdalena Slawinska added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Ruth Pottgen merged

    merged

  • Ruth Pottgen mentioned in commit c8885119

    mentioned in commit c8885119

Please register or sign in to reply