Add _p4 version of CscRawDataCnv

Hi,

this MR is a manual sweep of the 3 MRs !28146 (merged), !28231 (merged) and !28290 (merged) into 21.0-mc16a.

It adds a CscRawDataCnv_p4 converter since we moved from using CSC identifier hashes which reflect the geometrical position of the CSCs to the actual index of the identifier in the vector of identifiers (positional hash) in !24467 (merged) in master.

For the 21.0 releases, we want to keep the old geometrical channel identifier hashes as baseline in the transient format. Thus only the _p4 version of the converters translates positional identifier hashes from the persistent p4 files back to geometrical channel identifier hashes needed by the 21.0 transient model. There is also a transToPers() implementation for p4 which however is not the default for 21.0.

The content of the CscRawData still stays as in version p3, just the meaning of m_hashId changes from geometrical to positional hash.

Adding @mnowak, @jchapman

added sweep:ignore label

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonEventAthenaPool
• MuonSpectrometer/MuonIdHelpers

Adding @rosati ,@wleight ,@nkoehler as watchers

added 21.0-mc16a MuonSpectrometer review-pending-level-1 labels

CI Result FAILURE (hash c463cfed)

	Athena
externals
cmake
make
required tests
optional tests	N/A

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 296
For experts only: Jenkins output [CI-MERGE-REQUEST 41679]

added review-user-action-required label and removed review-pending-level-1 label

Hi @nkoehler,

Could you please take a look at this error:

-diff: ../../share/ESD-20.1.7.2.pool.root.ref: No such file or directory
 CoralApplication Info Delete the COOL CoralApplication...
 CoralApplication Info Delete the COOL database service
 RalDatabaseSvc Info Delete the RalDatabaseSvc...
post.sh> ERROR: MuonEventTPCnv_20.1.7.2.log and ../share/MuonEventTPCnv_20.1.7.2.ref differ

Regards,

Ana (L1)

added 1 commit

• 761f8c6a - fix MuonEventTPCnv unit tests

Compare with previous version

This merge request affects 3 packages:

• Database/AthenaPOOL/AthenaPoolUtilities
• MuonSpectrometer/MuonCnv/MuonEventAthenaPool
• MuonSpectrometer/MuonIdHelpers

Adding @rosati ,@wleight ,@mnowak ,@nkoehler ,@ssnyder as watchers

added Database review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash 761f8c6a)

	Athena
externals
cmake
make
required tests
optional tests	N/A

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 23
For experts only: Jenkins output [CI-MERGE-REQUEST 41690]

CI fine now, sweep, changes looks fine so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit e6af43c5

mentioned in merge request !36601 (merged)