DisplacedSoftPion TrackPatternRecoInfo

Hi,

In preparation for the upcoming December LLP data-reprocessing, I'm adding functionality to uniquely identify tracks reconstructed with the DisplacedSoftPion configuration (previous these were merged with the LargeD0 TrackPatternRecoInfo).

Cheers, Matthew

Tagging RPVlL conveners: @kpachal ,@jmontejo

unmarked as a Work In Progress

This merge request affects 4 packages:

• Event/xAOD/xAODTracking
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/SiTrackMakerTool_xk
• Tracking/TrkEvent/TrkTrack

Adding @goetz ,@amorley ,@sroe ,@rbianchi as watchers

added 21.0 EDM InnerDetector Tracking review-pending-level-1 labels

CI Result FAILURE (hash 6bb914b9)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 78
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41683]

Hi @mgignac,

Could you look into this error?

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.0/InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx: In member function 'virtual StatusCode InDetPhysValMonitoringTool::fillHistograms()':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.0/InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx:472:21: error: no match for 'operator|=' (operand types are 'std::bitset<52ul>' and 'std::bitset<53ul>')
           base_bits |= author_bitset;

Regards,

Ana (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 1fc2f381 - replacing hardcoded length of bitsets with xAOD::NumberOfTrackRecoInfo

Compare with previous version

Hi @anmrodri,

It looks like the InDetPhysValMonitoring had a number of places where they hardcoded the length of the std::bitset to 52, and didn't use xAOD::NumberOfTrackRecoInfo. I've updated those; can you please check.

Cheers, Matthew

This merge request affects 5 packages:

• Event/xAOD/xAODTracking
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/SiTrackMakerTool_xk
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• Tracking/TrkEvent/TrkTrack

Adding @goetz ,@amorley ,@sroe ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 1fc2f381)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 78
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41704]

Some warnings, which I believe are not related to the MR. Will send to L2 for double check. (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Agree, and do not see anything problematic here, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 4552e959

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• master

mentioned in merge request !28989 (merged)

mentioned in commit 1e705b32

mentioned in commit e49ae1a9

mentioned in merge request !30922 (merged)

mentioned in commit e58d6a4b

mentioned in merge request !31426 (merged)

mentioned in commit 9ee521d4