Write and read aligned TRT detector elements to and from the conditions store

This Merge request update the TRTAlignCondAlg to also create a container of aligned TRT detector elements (TRT_DetElementContainer) and to store it in the conditions store. It also update a few clients to use aligned detector elements read directly from the conditions store. Tagging @goetz and @mhodgkin so they are aware. This MR allows to close the following JIRA tickets: ATLASRECTS-4786 ATLASRECTS-4786t And address most of this, only the L3 alignment is missing: ATLASRECTS-5093

changed title from Write and read aligned TRT detector elements from the conditions store to Write and read aligned TRT detector elements to and from the conditions store

changed the description

This merge request affects 8 packages:

• InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs
• InnerDetector/InDetConditions/TRT_ConditionsAlgs
• InnerDetector/InDetDetDescr/InDetReadoutGeometry
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/TRT_DetElementsRoadTool_xk
• InnerDetector/InDetRecTools/TRT_DriftCircleOnTrackTool
• InnerDetector/InDetRecTools/TRT_DriftCircleTool
• InnerDetector/InDetRecTools/TRT_ToT_Tools

Adding @goetz ,@jajimene ,@amorley ,@calfayan ,@martis ,@sroe ,@cgrefe as watchers

added InnerDetector master review-pending-level-1 labels

Jenkins please retry a build

Hi @carquin,

Did you run RunTier0Tests.py to check if results are unchanged?

If pointers of TRT_BaseElement are used and compared in the tracking codes (drift circle, segment, track), you need to change all those codes to use TRT_BaseElement of condition store at the same time. Even if a TRT_BaseElement of TRT_DetectorManager and the corresponding TRT_BaseElement of condition store have identical positions, they are different objects.

Cheers, Susumu

Running it now, just surprised the pipeline fail just after starting...

CI Result FAILURE (hash b3639365)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6209]

TEST FAILURE: Digitization_NewConfig_required returned code 134

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• a2a68980 - Fix problem with TRT_DetElementContainer destructor and readCondHandle keys in...

Compare with previous version

This merge request affects 8 packages:

• InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs
• InnerDetector/InDetConditions/TRT_ConditionsAlgs
• InnerDetector/InDetDetDescr/InDetReadoutGeometry
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/TRT_DetElementsRoadTool_xk
• InnerDetector/InDetRecTools/TRT_DriftCircleOnTrackTool
• InnerDetector/InDetRecTools/TRT_DriftCircleTool
• InnerDetector/InDetRecTools/TRT_ToT_Tools

Adding @goetz ,@jajimene ,@amorley ,@calfayan ,@martis ,@sroe ,@cgrefe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake	N/A	N/A
make	N/A	N/A
required tests	N/A	N/A
optional tests	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6313]

Jenkins please retry a build

This merge request affects 8 packages:

• InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs
• InnerDetector/InDetConditions/TRT_ConditionsAlgs
• InnerDetector/InDetDetDescr/InDetReadoutGeometry
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/TRT_DetElementsRoadTool_xk
• InnerDetector/InDetRecTools/TRT_DriftCircleOnTrackTool
• InnerDetector/InDetRecTools/TRT_DriftCircleTool
• InnerDetector/InDetRecTools/TRT_ToT_Tools

Adding @goetz ,@jajimene ,@amorley ,@calfayan ,@martis ,@sroe ,@cgrefe as watchers

CI Result SUCCESS (hash a2a68980)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6314]

Everything looks good, moving towards L2 review. -L1

added review-pending-level-2 label and removed review-pending-level-1 label

Do not see anything problematic as well, approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

Hi @carquin,

Did you get RunTier0Tests.py results?

Cheers, Susumu

Hi @oda, Yes, they are not run by the CI? I can post the log file here as well if needed. Cheers, Edson

Right, RunTier0Tests.py is not run by the CI. If everything was OK there, then I'll go ahead and merge this MR.

Hi @carquin , could you please confirm that RunTier0Tests.py came out clean for your MR?

Hi @carquin

As I said in person, I didn't see differences in q221 (with MC with perfect alignment) and saw differences in q431 (with data with non-zero alignment constants). RunTier0Tests.log

Cheers, Susumu

Hi @oda and @tsulaia, Yes, I saw the same. Will investigate further the source of the differences. Cheers, Edson

Will add the label to review user action required in the meantime

added review-user-action-required label

removed review-approved label

Hello! after !28778 (merged) was merged, tried again the FrozenTier0 Tests and they all succeeded (Attaching output fileRunTier0Tests.log), could this be merged then?

INFO     -----------------------------------------------------
INFO     ---------------------- Summary ----------------------
INFO     ALL TESTS: PASSED (0)

removed review-user-action-required label

This merge request affects 8 packages:

• InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs
• InnerDetector/InDetConditions/TRT_ConditionsAlgs
• InnerDetector/InDetDetDescr/InDetReadoutGeometry
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/TRT_DetElementsRoadTool_xk
• InnerDetector/InDetRecTools/TRT_DriftCircleOnTrackTool
• InnerDetector/InDetRecTools/TRT_DriftCircleTool
• InnerDetector/InDetRecTools/TRT_ToT_Tools

Adding @goetz ,@jajimene ,@amorley ,@calfayan ,@martis ,@sroe ,@gavrilen ,@cgrefe as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash a2a68980)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7218]

removed review-pending-level-1 label

The review was already approved a week ago, additional evidence of this MR is not breaking the Frozen Tier0 policy, could we merge?
Removing the level1 review label and adding the review-approved one to make it explicit.

added review-approved label

merged

mentioned in commit 96a005ac

changed the description

added sweep:ignore label