Add independent variable to store a normalization energy for TFCSPCAEnergyParametrization

For the correct interplay with the energy selection of parametrization and the interpolation, an Independent variable is needed to store the energy normalization for TFCSPCAEnergyParametrization

added 21.0 Simulation labels

added 1 commit

• 8f843e4f - Update copyright statement

Compare with previous version

added 1 commit

• 5baf7599 - Add custom streamer to TFCSPCAEnergyParametrization for backward compatibility

Compare with previous version

unmarked as a Work In Progress

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 5baf7599)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41816]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5d3547ae

added sweep:done label

mentioned in commit bf037253

mentioned in merge request !28612 (merged)

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/991/console for details)

Hi @mduehrss, I think this breaks standalone build due to schema evolution. Can I update the standalone code to use this change as it seems backwards compatible?

Hi @tadej,

in principle it should be backward compatible due to the custom streamer. I just tried standalone with this MR and it worked, so I don't see a reason why it shouldn't be used also for the standalone code. However, @jbeirer was seeing an energy of exactly zero with this change, so perhaps best to wait to make sure it's not breaking something.

It seems it does not build at the moment (due to LinkDef issues). I guess + has to be changed to -.

yes, the custom streamer means LinkDef needs to be changed from + to -

mentioned in commit 8462713d

mentioned in merge request !28989 (merged)

mentioned in commit 1e705b32