New SCT barrel alignment per eta-ring

Add a new SCT barrel software alignment level. Alignment of SCT barrel modules per rings (eta ring). New barrel level 25. complements the equivalent alignment level in the endcaps, already existing.

This merge request affects 2 packages:

• InnerDetector/InDetAlignment/InDetAlignDBTools
• InnerDetector/InDetAlignment/InDetAlignGeomTools

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

added 21.0 InnerDetector review-pending-level-1 labels

CI Result SUCCESS (hash 40e3d45f)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 159
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 41858]

Hi @martis,

I have some minor comments.

Tadej (L2)

added review-user-action-required label and removed review-pending-level-1 label

Dear @tadej,

I have following your advice, in many cases it work, in some others it may need some extra work. I am running a local test. If successful I will commit the latest amendments.

Cheers Salva

added 2 commits

• ac03f6d2 - Code amendements suggested by L2 on MR 28614
• 268d26ce - Code amendements suggested by L2 on MR 28614

Compare with previous version

resolved all threads

Corrections committed

This merge request affects 2 packages:

• InnerDetector/InDetAlignment/InDetAlignDBTools
• InnerDetector/InDetAlignment/InDetAlignGeomTools

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 268d26ce)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 159
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 41882]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• d0088d16 - Code amendements suggested by L1 on MR 28614 20191210

Compare with previous version

Corrections committed

resolved all threads

This merge request affects 2 packages:

• InnerDetector/InDetAlignment/InDetAlignDBTools
• InnerDetector/InDetAlignment/InDetAlignGeomTools

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 2 commits

• 7f87fd27 - SCTGeometryManagerTool.cxx printout: from DEBUG to INFO
• 53217ebd - SCTGeometryManagerTool use dynamic_cast<const Trk::TrkDetElementBase *>

Compare with previous version

CI Result SUCCESS (hash d0088d16)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 159
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 41903]

This merge request affects 2 packages:

• InnerDetector/InDetAlignment/InDetAlignDBTools
• InnerDetector/InDetAlignment/InDetAlignGeomTools

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

CI Result SUCCESS (hash 53217ebd)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41921]

Hi @martis , the warning is about a not used variable in a function declaration.

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.0/InnerDetector/InDetAlignment/InDetAlignDBTools/src/SiTrkAlignDBTool.cxx:670:111: warning: unused parameter 'apBowX' [-Wunused-parameter] void SiTrkAlignDBTool::updateAsL3(const Trk::AlignModule * module, const Amg::Transform3D & transform, double apBowX)

Could you check whether the variable name can be removed?

Eric, L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 6d4c025d - SiTrkAlignDBTool: uncomment lines for avoid apBowX warnings

Compare with previous version

Concerning the apBowX, I uncommented few lines to avoid the warning message. This parameter is related with the IBL bowing.

This merge request affects 2 packages:

• InnerDetector/InDetAlignment/InDetAlignDBTools
• InnerDetector/InDetAlignment/InDetAlignGeomTools

Adding @goetz ,@jajimene ,@martis ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

let's go Jenkins

CI Result SUCCESS (hash 6d4c025d)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41942]

resolved all threads

Thank you for removing the warning. Approving MR. Eric, L1