Make DoubleEventSelectorAthenaPool more flexible

This is an alternative to !24443 (closed). As @gemmeren suggested we can make DoubleEventSelectorAthenaPool more flexible by inheriting EventSelectorAthenaPool and adding the secondary event selector as a property so can be interchanged. This will also allow EventSelectorByteStream to be used as secondary one.

/cc @jchapman @mmuskinj

changed the description

Hi @tadej , will this eventually deprecate DoubleEventSelectorAthenaPool.cxx?

Yes, that's the idea. The goal is to have one DoubleEventSelector class which would support both POOL+POOL and POOL+BS.

Hi @tadej , I had a glance at your proposed changes and they look good to me. (I may have a slight preference for keeping the name DoubleEventSelectorAthenaPool, because the primary ES is POOL, but no biggie). Peter

added 1230 commits

• b9aa05c0...234f18b0 - 1229 commits from branch atlas:master
• 7e6041e7 - Make DoubleEventSelectorAthenaPool more flexible

Compare with previous version

added 1 commit

• 7ed01408 - Make DoubleEventSelectorAthenaPool more flexible

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Add a more flexible DoubleEventSelector to Make DoubleEventSelectorAthenaPool more flexible

changed the description

I think this one is ready for review. I will do some more regression tests myself but things look OK now.

WARNING: big files (>100K) are found in the changeset

412K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/ReadRDODoubleSelector.ref

This merge request affects 6 packages:

• AtlasTest/DatabaseTest/AthenaPoolTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/EventSelectorAthenaPool
• Event/EventOverlay/EventOverlayJobTransforms
• Event/xAOD/xAODEventInfoCnv

Adding @jchapman ,@ahaas ,@tkharlam ,@tadej ,@ssnyder ,@rbianchi ,@mnowak as watchers

added Core Database EDM Overlay Test master review-pending-level-1 labels

CI Result FAILURE (hash 7ed01408)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7870]

added 1 commit

• f8ac5fc6 - Make DoubleEventSelectorAthenaPool more flexible

Compare with previous version

WARNING: big files (>100K) are found in the changeset

412K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/ReadRDODoubleSelector.ref

This merge request affects 6 packages:

• AtlasTest/DatabaseTest/AthenaPoolTest
• Control/AthenaKernel
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/EventSelectorAthenaPool
• Event/EventOverlay/EventOverlayJobTransforms
• Event/xAOD/xAODEventInfoCnv

Adding @jchapman ,@ahaas ,@tkharlam ,@tadej ,@ssnyder ,@rbianchi ,@mnowak as watchers

mentioned in merge request !29322 (merged)

CI Result FAILURE (hash f8ac5fc6)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7878]