Adding BCID dependence to Zcounting histograms

Added

• BunchCrossingTool
• 3D BCID dependent histograms
• Auxiliary histogram filling function to tidy up the logic/repeated calls

This merge request affects 1 package:

• DataQuality/DataQualityTools

added 21.0 DQ review-pending-level-1 labels

CI Result FAILURE (hash dc41e8c0)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41872]

Jenkins please retry a build

This merge request affects 1 package:

• DataQuality/DataQualityTools

CI Result FAILURE (hash dc41e8c0)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 159
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 41875]

Not clear what the problem with the CI is, scaling to L2

added review-pending-level-2 label and removed review-pending-level-1 label

added 1 commit

• 9beca2cb - Tidying up discussion comments

Compare with previous version

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-pending-level-2 label

resolved all threads

CI Result FAILURE (hash 9beca2cb)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41896]

The q221 test failes and there are a lot of warnings like this about connection failures:

HITtoRDO 12:39:14 CORAL/Services/ConnectionService Warning Failed to connect to service sqlite200/ALLP200.db (coral::Exception): 'CORAL/RelationalPlugins/sqlite ( CORAL : "Connection::connect" from "/var/lib/jenkins/workspace/CI-test-driver/CI-test-driver_28641_36477/Athena/qTestsTier0_required/run_q221/sqlite200 is not writable" )' - do NOT retry

I would think this is not connected to the MR, asking L2. Eric, L1

added review-pending-level-2 label and removed review-pending-level-1 label

added review-user-action-required label

@pavol Is there some action I need to take here or is that tag not for me?

@ebuschma @pavol Any update on this MR? Thanks!

Rerun CI to check warnigs.

Jenkins please retry a build

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

CI Result FAILURE (hash 9beca2cb)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42112]

Hi @tadej , could you have a look at the failing test? I am a bit lost in the log file, there are so many warnings. Thank you.

Cheers, Eric (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

"TypeError: attempt to redefine type of "BunchCrossingTool" (was: Trig__MCBunchCrossingTool, new: Trig__TrigConfBunchCrossingTool)")

added review-user-action-required label and removed review-pending-level-2 label

Jenkins please retry a build

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 9beca2cb)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 158
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 42279]

Hi, many Athena warnings observed in other few MRs too. (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Jenkins please retry a build

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-pending-level-2 label

CI Result FAILURE (hash 9beca2cb)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 158
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 42299]

Hi, the persisting problem is:

• TEST FAILURE: qTestsTier0_required returned code 255

Compilation warnings are not related to DataQuality/DataQualityTools.

Magdalena (L1)

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 39029f18 - Adding different histograms for different bunch structures

Compare with previous version

This merge request affects 1 package:

• DataQuality/DataQualityTools

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 39029f18)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42336]

The test qTestsTier0_required failed again. @miokeefe , do you think it is not related to your changes or you are working on a fix? I see that this test succeeded in other MR to 21.0. This is why it seems to me the failure is related with your changes. But if you do not think so, let us know.

L1 shifter

added review-user-action-required label