Skip to content
Snippets Groups Projects

Add variables to EventInfo for LHC train structure

Merged Christopher Young requested to merge cyoung/athena:21.2-JETM-BCID into 21.2
All threads resolved!

For a BCID based correction we will require a few variables added to event info which use the LHC train structure to translate BCID into distance from the front of the train and the gap before the train such that we can determine if we are after an abort gap or after a long gap. For 8b4e as the tool treats all 8 bunch sets as a train we also store the situation 12 BCIDs before to see if we are in the first two sets of 8 bunches from a long gap.

Merge request reports

Pipeline #1287045 passed

Pipeline passed for 9710d976 on cyoung:21.2-JETM-BCID

Approval is optional

Merged by Oana Vickey BoeriuOana Vickey Boeriu 5 years ago (Dec 11, 2019 7:34pm UTC)

Merge details

  • Changes merged into with d2a03da9.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christopher Young resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Because of urgent, adding now the approved label for later reference, even if the robot changes it again. Last commit should not change CI tests. Eric, L1

  • added review-approved label and removed review-pending-level-1 label

  • This merge request affects 1 package:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

    Adding @jmellent ,@nelsonc ,@ispokhar as watchers

  • added review-pending-level-1 label and removed review-approved label

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 9710d976)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 41915]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 9710d976)

    AnalysisBase AnalysisTop AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisTop: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 3
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6837]

  • Warnings are not related to this MR, otherwise looks fine, approving.

    Pavol [as L2 MR shifter]

  • mentioned in commit d2a03da9

  • Louis Portales mentioned in merge request !28822 (merged)

    mentioned in merge request !28822 (merged)

  • Chris Malena Delitzsch resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading