Simplify EventViewCreationAlgorithm(s)

Prompted by a discussion on a different MR, simplify the various EVCAs by removing an unnecessary step.

Following discussion with @tamartin, it seems that the step was intended to do something (attach RoI to EventContext) but this wasn't actually happening. Have now added code to ViewHelper.h so that it does now do that correctly.

Also removed a bunch of trailing whitespace

Tagging @fwinkl @fpastore @tbold

changed the description

added 11 commits

• 41d5d11d...ede5b94f - 10 commits from branch atlas:master
• baef7289 - Merge branch 'master' of https://gitlab.cern.ch/atlas/athena into SimplifyEVCA

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigSteer/ViewAlgs

Adding @tamartin as watcher

added Trigger master review-pending-level-1 labels

So, Ben, we don’t need setExtendedEventContext anymore?

added 1 commit

• 7cb79403 - Set the Roi in the event context that is actually going to be used

Compare with previous version

changed the description

This merge request affects 2 packages:

• Control/AthViews
• Trigger/TrigSteer/ViewAlgs

Adding @tamartin ,@ssnyder as watchers

added Core label

CI Result SUCCESS (hash baef7289)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6991]

CI Result FAILURE (hash 7cb79403)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 6998]

added 1 commit

• bff845c9 - Made the RoI->EventContext link optional in case there is no RoI

Compare with previous version

This merge request affects 2 packages:

• Control/AthViews
• Trigger/TrigSteer/ViewAlgs

Adding @tamartin ,@ssnyder as watchers

Jenkins please retry a build

Job restarted after the finish of a scheduled intervention on the Jenkins CI server

This merge request affects 2 packages:

• Control/AthViews
• Trigger/TrigSteer/ViewAlgs

Adding @tamartin ,@ssnyder as watchers

CI Result SUCCESS (hash bff845c9)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7056]

resolved all threads

Approving MR. Eric, L1

added review-approved label and removed review-pending-level-1 label