Skip to content
Snippets Groups Projects

Remove phased-out MuGirlTagTool from configuration

Merged Nicolas Koehler requested to merge nkoehler/athena:muGirlTrig into master

Hi @wleight, @wlampl, @sshaw,

this MR should fix the failing TriggerMenu_generateMenu_ctest and TriggerMenuMT_generateMenuMT_ctest mentioned by @wlampl in !28577 (merged).

Best, Nico

Edited by Nicolas Koehler

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • My guess would be that the reason for the error is because you accidentally deleted the MuonInsideOutRecoTool from MuonCombinedRecExampleConfigDb.py, though I'm a bit surprised that the non-MT test worked in that case.

  • Probably the non-MT test is fine because we don't used the version of the tool defined in the offline config:

    https://gitlab.cern.ch/atlas/athena/blob/master/Trigger%2FTrigAlgorithms%2FTrigMuonEF%2Fpython%2FTrigMuonEFConfig.py#L423

  • Ah, that makes sense then, thanks!

  • Nicolas Koehler added 27 commits

    added 27 commits

    Compare with previous version

  • Nicolas Koehler resolved all threads

    resolved all threads

  • Nicolas Koehler changed the description

    changed the description

  • This merge request affects 2 packages:

    • Reconstruction/MuonIdentification/MuonCombinedRecExample
    • Trigger/TrigAlgorithms/TrigMuSuperEF

    Adding @goetz ,@rosati ,@nkoehler ,@wleight as watchers

  • Jenkins please retry a build

  • Jenkins please retry a build

  • Jenkins please retry a build

  • I tried a retry 3 times, but it does not seem to want to succeed. Pinging @aundrus

  • I think it's all ready running here (from your last commit):

    https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-CC7/7099/

    (there's messages in the failed jobs you retried about them being duplicates).

  • good point, why does then gitlab tell me, that the pipeline failed: image

  • I guess this organises the pipelines by commits, and shows only the latest one. I'm not sure if there's a way to see the previous pipelines from this somehow (actually, the only way I know to find this is by looking at all the recent pipelines here: https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-CC7/ but there certainly could be a easier way that I'm not aware of).

  • :negative_squared_cross_mark: CI Result FAILURE (hash 16541a61)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7096]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading