Add TrigCaloDataAccessSvc and CaloBCIDAvgAlg to the beginning of the sequence

Add TrigCaloDataAccessSvc and CaloBCIDAvgAlg to the beginning of the sequence...

This merge request affects 1 package:

• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@jpanduro as watchers

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 28c4e251)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7280]

Py:LuminosityCondAlg ERROR Inconsistent isOnline setting is appearing in many tests now.. Maybe @rbielski can help?! I am not sure I have control over the other failures.. Cheers, Denis

Well, can you explain what is meant here:
https://gitlab.cern.ch/atlas/athena/blob/master/LumiBlock/LumiBlockComps/python/LuminosityCondAlgDefault.py#L12-29

Why is there _isOnline = False and then there is global _isOnline and a check for if isOnline and not _isOnline? This looks to be preventing LuminosityCondAlgDefault from being used online? So either someone has to fix that code or some other function should be used online?

As far as I see this is the only problem in the CI.

Well, I cannot, but maybe @wlampl or @gunal can.. Or know who can.. Or @akraszna...

Or @ssnyder

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@jpanduro as watchers

CI Result FAILURE (hash 28c4e251)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7311]

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@jpanduro as watchers

Hi @maslawin, @pberta,
no point restarting this one until the code is fixed.

Not sure what to do about the Luminosity tool. We depend on that. And we need the help of @wlampl, @gunal or @ssnyder.. Now, why it failed the make (which it passed the first time).. Cheers, Denis

It didn't fail the make. There was an unrelated compilation error in the second round which (I think) got fixed since then.

CI Result FAILURE (hash 28c4e251)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7385]

LuminosityCondAlgDefault will set up for offline, unless online has already been requested. If you try to request online after offline has already been configured, then you get the error.

You need to be sure that you request online the first time you set up the lumi algorithm. For example:

diff --git a/Trigger/TrigAlgorithms/TrigT2CaloCommon/python/TrigT2CaloCommonConfig.py b/Trigger/TrigAlgorithms/TrigT2CaloCommon/python/TrigT2CaloCommonConfig.py
index babe07b5b821..e11652bc7559 100644
--- a/Trigger/TrigAlgorithms/TrigT2CaloCommon/python/TrigT2CaloCommonConfig.py
+++ b/Trigger/TrigAlgorithms/TrigT2CaloCommon/python/TrigT2CaloCommonConfig.py
@@ -64,6 +64,8 @@ class TrigCaloDataAccessSvc(_TrigCaloDataAccessSvc):
                     condSequence = AthSequencer("AthCondSeq")
                     from LArRecUtils.LArRecUtilsConf import LArFlatConditionsAlg_LArOFCFlat_ as LArOFCCondAlg
                     condSequence += LArOFCCondAlg (ReadKey="/LAR/ElecCalibFlat/OFC", WriteKey='LArOFC')
+                    from LumiBlockComps.LuminosityCondAlgDefault import LuminosityCondAlgOnlineDefault
+                    LuminosityCondAlgOnlineDefault()
                     from CaloRec.CaloBCIDAvgAlgDefault import CaloBCIDAvgAlgDefault
                     CaloBCIDAvgAlgDefault()
                     from AthenaCommon.AlgSequence import AlgSequence

Hello @rbielski, I am testing this solution here, but I am not being able to get it working because I am base on r12, so, it is failing due to that issue with the initBCID. Is there a way around it?! I am trying to fetch upstream, but I am afraid this may bring more problems.. Denis

I just did a git fetch upstream git stash git merge upstream/master git stash pop Now I am not sure what I should compile (now I have many packages in my sparse checkout) to fix this initBCID. Did I do the right thing?! @rbielski or @tamartin ? Denis

Hi @damazio,
the fix is in the nightly, you don't need to compile any extra packages. After you merged with upstream, just clean your build directory, do asetup Athena,master,latest in a new terminal, and compile the packages you had checked out previously.

ok.. Now I managed to do and test it. Seems to fix..

added 358 commits

• 28c4e251...8c171f3d - 356 commits from branch atlas:master
• 385365b1 - Merge remote-tracking branch 'upstream/master' into ATR-20688_20191217
• 26a2f947 - fixing as Scott suggested, using the online Luminosity Tool

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @joheinri ,@damazio ,@hartj ,@jpanduro as watchers

CI Result SUCCESS (hash 26a2f947)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7473]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @joheinri ,@damazio ,@hartj ,@jpanduro as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake	N/A	N/A
make	N/A	N/A
required tests	N/A	N/A
optional tests	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7514]

Not sure what to do about this...

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest

Adding @joheinri ,@damazio ,@hartj ,@jpanduro as watchers

Unfortunately I do... The issue in the build is:

CMake Warning at CMakeLists.txt:22 (find_package):
  By not providing "FindAthenaExternals.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "AthenaExternals", but CMake did not find one.

  Could not find a package configuration file provided by "AthenaExternals"
  with any of the following names:

    AthenaExternalsConfig.cmake
    athenaexternals-config.cmake

  Add the installation prefix of "AthenaExternals" to CMAKE_PREFIX_PATH or
  set "AthenaExternals_DIR" to a directory containing one of the above files.
  If "AthenaExternals" provides a separate development package or SDK, be
  sure it has been installed.


CMake Error at CMakeLists.txt:23 (gaudi_ctest_setup):
  Unknown CMake command "gaudi_ctest_setup".


-- Configuring incomplete, errors occurred!
See also "/build2/ci-builds/master/Athena/build/GAUDI/CMakeFiles/CMakeOutput.log".

It comes from !28712 (merged). That MR "tainted" the aibuild20-048 build node yesterday. The re-build should succeed.

We could in principle ask for a clean of the nodes, but it's already Friday. So just a dumb re-build will probably work better. The shifter should nevertheless keep an eye on the master failures on aibuild20-048.

CI Result SUCCESS (hash 26a2f947)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7518]

Can we still merge this?? Thanks Denis

Look ok now, approving & merging.

• Walter

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 049e6a2a

added sweep:ignore label