Skip to content
Snippets Groups Projects

Various minor clean-ups in the HLT domain

Merged Rafal Bielski requested to merge rbielski/athena:hlt-cleanup into master
All threads resolved!

A little Christmas clean-up. I went through several (but not all) packages in the HLT directory and made minor fixes, including:

:christmas_tree: fixing typos

:santa: removing empty constructor / destructor

:gift: flake8 fixes

:snowflake: CMake fixes

:snowman: removing obsolete files

:tada: adding copyright statement

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rafal Bielski added 1 commit

    added 1 commit

    • f576c2dd - Various minor clean-ups in the HLT directory

    Compare with previous version

  • Frank Winklmeier resolved all threads

    resolved all threads

  • This merge request affects 5 packages:

    • HLT/Trigger/TrigControl/TrigCommon
    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • HLT/Trigger/TrigControl/TrigKernel
    • HLT/Trigger/TrigControl/TrigPSC
    • HLT/Trigger/TrigControl/TrigServices

    Adding @wiedenma ,@bernius ,@fwinkl ,@rbielski as watchers

  • :white_check_mark: CI Result SUCCESS (hash 06865b97)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7369]

  • :white_check_mark: CI Result SUCCESS (hash f576c2dd)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7378]

  • The changes look ok. Adding review-approved label.

    L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit e5f6516c

    mentioned in commit e5f6516c

  • Rafal Bielski mentioned in merge request !29089 (merged)

    mentioned in merge request !29089 (merged)

  • Please register or sign in to reply
    Loading