Skip to content
Snippets Groups Projects

ThinningUtils+CaloRec+JetRec+eflowRec: Migrate to MT thinning.

Merged Scott Snyder requested to merge ssnyder/athena:thinning.ThinningUtils-20191219 into master
All threads resolved!

Migrate thinning tools in this ThinningUtils to use new MT thinning.

Need to adjust clients so that they specify the stream when creating the thinning algorithms.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Except for print statements, MR is ok, warnings a general problem. For later reviewer. Eric, L1

  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • Jenkins please retry a build

  • This merge request affects 4 packages:

    • Calorimeter/CaloRec
    • PhysicsAnalysis/AnalysisCommon/ThinningUtils
    • Reconstruction/Jet/JetRec
    • Reconstruction/eflowRec

    Adding @goetz ,@pavol ,@mhodgkin as watchers

  • :white_check_mark: CI Result SUCCESS (hash 4fc653da)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7600]

  • Approving MR. Eric, L1

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Walter Lampl mentioned in commit 29ccdfca

    mentioned in commit 29ccdfca

  • Please register or sign in to reply
    Loading