Skip to content
Snippets Groups Projects

TrigKernel: Further clean-up and make it a header-only library

Merged Rafal Bielski requested to merge rbielski/athena:trigkernel-cleanup into master

Further clean-up of the TrigKernel package following up from !29024 (merged):

  • Remove HltExtraStatusCode - although it has been possibly recorded in some Run-2 data, it has never been used and it seems no decoding of these codes has ever been implemented in Athena
  • Remove HltOnlHelper which was only serving the purpose of enum->string mapping
  • Implement much cleaner way of enum->string mapping for the remaining enum PSCErrorCode
  • Adapt clients to the above change
  • Thanks to the above, it was now possible to make TrigKernel a header-only library

Merge request reports

Pipeline #1308599 passed

Pipeline passed for b85cc000 on rbielski:trigkernel-cleanup

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 5 years ago (Dec 23, 2019 2:11am UTC)

Merge details

  • Changes merged into master with a45bc810.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading