L1 bug fixes 21.3

• LArCalorimeter/LArL1Sim: Initial method to provide estimate of supercell time. Known to have some physics issues, but provides a starting point.
• Trigger/TrigL1Upgrade: Change the input / output containers for pedestal corrections
• Trigger/TrigT1/TrigT1CaloFexSim

1. Bug fix for MET x,y components in pufit: ATR-20288
2. Ability to emulate supercell timing rather than use the bit mask (only for experimental studies)
3. Bug fixes for pileup subtraction
4. Enable gBlock jets

added 21.3 Run3L1Calo Trigger alsoTargeting:21.9 labels

changed the description

@amyers @viveiros

added 1 commit

• 14082445 - Bug fix for rho subtraction

Compare with previous version

added 1 commit

• 163ef7ed - commit changes to keep rho

Compare with previous version

unmarked as a Work In Progress

This merge request affects 3 packages:

• LArCalorimeter/LArL1Sim
• Trigger/TrigL1Upgrade/TrigL1CaloUpgrade
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @pavol ,@kwhalen ,@afaulkne as watchers

added JetEtmiss LAr review-pending-level-1 labels

CI Result SUCCESS (hash 163ef7ed)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 42392]

We've got some compiler warnings about unused variables:

22:28:57 In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TrigT1/TrigT1CaloFexSim/src/METAlg.cxx:16:0:
22:28:57 /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TrigT1/TrigT1CaloFexSim/TrigT1CaloFexSim/JwoJ.h: In function 'std::vector<float> Run_JwoJ(const JGTowerContainer*, std::vector<TowerObject::Block>, float, float, bool, bool)':
22:28:57 /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TrigT1/TrigT1CaloFexSim/TrigT1CaloFexSim/JwoJ.h:28:164: warning: unused parameter 'useNegTowers' [-Wunused-parameter]
22:28:57  std::vector<float> Run_JwoJ(const xAOD::JGTowerContainer* towers, const std::vector<TowerObject::Block> blocks, float rho, float pTcone_cut, bool useEtaBins, bool useNegTowers){
22:28:57                                                                                                                                                                     ^~~~~~~~~~~~
22:28:57 /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TrigT1/TrigT1CaloFexSim/src/METAlg.cxx: In static member function 'static StatusCode METAlg::JwoJ_MET(const JGTowerContainer*, std::vector<TowerObject::Block>, TString, float, bool, bool, bool)':
22:28:57 /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TrigT1/TrigT1CaloFexSim/src/METAlg.cxx:313:9: warning: unused variable 'phi' [-Wunused-variable]
22:28:57    float phi = 0;
22:28:57          ^~~

Please fix these & then change the tags back. --L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• d932719c - fixing compiler warnings

Compare with previous version

Hi @etolley, I think I have fixed the warnings. I do not see warnings in my local compilation now. Ben

Jenkins please retry a build

This merge request affects 3 packages:

• LArCalorimeter/LArL1Sim
• Trigger/TrigL1Upgrade/TrigL1CaloUpgrade
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @pavol ,@kwhalen ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash d932719c)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 160
For experts only: Jenkins output [CI-MERGE-REQUEST 42418]