Also testing for SimulateCavern for EtaPhiFilter

At the request of @menke , adding a test for the simulate cavern flag before adding the eta/phi filter. I can't think of any situation in which we would want to simulate the cavern but we would not want to simulate forwward particles. After discussion with @jchapman , he agreed with the addition.

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Services

Adding @jchapman ,@vpascuzz as watchers

added 21.0 Simulation review-pending-level-1 labels

Hi @zmarshal, thanks! I had to go a few times through the not/or/and logic and brackets and I think it is correct. The original version did not need the round brackets ... and that confused me at first ... Cheers, --Sven

Looks good to me too - thanks Zach!

CI Result SUCCESS (hash 8ff4c958)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42230]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 68172a3c

added sweep:done label

mentioned in commit e7d4bbbc

mentioned in merge request !29527 (merged)

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1031/console for details)

mentioned in commit a26f1a48

mentioned in merge request !30190 (merged)

mentioned in commit b20fd5eb