Eta requirement for b-jets in order not to run tracking outside the ID acceptance

Description: Setting an eta requirement in order to avoid the tracking to be performed outside the ID acceptance.

JIRA: ATR-16520

Hi, changing to 2.9 is ok for the R=0.4 jets, but might be too narrow for the R=0.7 jets, or the R=1 jets.

Ideally, this parameter would be set in the python configurable depending on the configuration of the chain itself, such that the value used by the jet selector is dependent on the jet radius parameter when the chains are configured in the menu.

Cheers Mark

I agree. The JetEtaMax property will be set in the python configuration.

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@sekula ,@cvarni ,@jpanduro as watchers

added JetEtmiss Trigger master review-pending-level-1 labels

OK, great.

Cheers Mark

CI Result FAILURE (hash 1c5ba865)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8139]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@sekula ,@cvarni ,@jpanduro as watchers

No point in retrying the build. There is a count change and the reference needs to be updated if this is understood:

112c112
< TrigSignatureMoniMT                                INFO HLT_j45_ftf_subjesgscIS_bmv2c1070_split_L1J20 decisions                    18        48        48        0         0
---
> TrigSignatureMoniMT                                INFO HLT_j45_ftf_subjesgscIS_bmv2c1070_split_L1J20 decisions                    18        49        49        0         0
114c114
< TrigSignatureMoniMT                                INFO HLT_j45_ftf_subjesgscIS_boffperf_split_L1J20 decisions                    18        48        48        0         0
---
> TrigSignatureMoniMT                                INFO HLT_j45_ftf_subjesgscIS_boffperf_split_L1J20 decisions                    18        49        49        0         0

Sorry, I was fast

As the MR already updated the reference I suspected it's the usual issue.

CI Result FAILURE (hash 1c5ba865)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8154]

I should've mentioned the differing reference file is:
https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TrigValidation/TrigAnalysisTest/share/q221_RDOtoRDOTrig_mt1_build.ref

added review-user-action-required label and removed review-pending-level-1 label

Please fix test failure and relabel. Magdalena (L1)

added 1 commit

• 841f2669 - Update of reference file q221_RDOtoRDOTrig_mt1_build.ref

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@cvarni ,@sekula ,@jpanduro as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 841f2669)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8373]

This was just to check the CI. I may apply a few very small changes.

Maybe make MR WIP until you are ready.

marked as a Work In Progress

changed the description

added 268 commits

• 841f2669...4f77de1f - 266 commits from branch atlas:master
• 86dcda20 - Configuring the JetMaxEta property from python code
• 1f461139 - Merge remote-tracking branch 'upstream/master' into IDacceptance

Compare with previous version

unmarked as a Work In Progress

After discussion with the b-jet group, I've applied a few changes so that the eta cut is now configured in python code. Also sync with master.

Removing WIP

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@cvarni ,@sekula ,@jpanduro as watchers

added TriggerMenu label

CI Result SUCCESS (hash 1f461139)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8388]

CI and changes look good. Approving.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit f6d158f4

added sweep:ignore label

mentioned in merge request !29095 (merged)