Skip to content
Snippets Groups Projects

Backport some ISF_FastCaloSimEvent fixes from master

Merged Tadej Novak requested to merge tadej/athena:FCS_sync_from_master into 21.0
All threads resolved!

Backport some ISF_FastCaloSimEvent fixes from master to enable easier sweeps.

Merge request reports

Pipeline #1377721 passed

Pipeline passed for 69745ff4 on tadej:FCS_sync_from_master

Approval is optional

Merged by Ruth PottgenRuth Pottgen 5 years ago (Feb 3, 2020 11:50am UTC)

Merge details

  • Changes merged into 21.0 with fb064765.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak added 1 commit

    added 1 commit

    • 69745ff4 - Backport some ISF_FastCaloSimEvent fixes from master

    Compare with previous version

  • Tadej Novak resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

  • :white_check_mark: CI Result SUCCESS (hash 69745ff4)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthDataQuality: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42469]

  • The changes look ok. Adding review-approved label.

    L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Ruth Pottgen mentioned in commit fb064765

    mentioned in commit fb064765

  • John Derek Chapman mentioned in merge request !30190 (merged)

    mentioned in merge request !30190 (merged)

  • Nicholas Styles mentioned in commit b20fd5eb

    mentioned in commit b20fd5eb

  • Please register or sign in to reply
    Loading