Skip to content
Snippets Groups Projects

MVAUtils: Adding support for XGBoost

Merged Yuan-Tang Chou requested to merge yuchou/athena:21.2-XGBoost-MVAUtils into 21.2

Adding derived class to support XGboost node/forest in MVAUtils. A python utility to convert the model saved by XGBoost training to our TTree format is also provided. Implementation follows closely with what was done in lgbm, presently only support regression and binary classification.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christos Anastopoulos added 1 deleted label

    added 1 deleted label

  • Yuan-Tang Chou added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Reconstruction/MVAUtils

    Adding @goetz ,@turra as watchers

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 6d170bfe)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42302]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 6d170bfe)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 3
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8345]

  • Please resolve discussion threads and relabel. Magdalena (L1)

  • Yuan-Tang Chou added 1 commit

    added 1 commit

    • c5cabe3f - Update copyright statement to 2020

    Compare with previous version

  • This merge request affects 1 package:

    • Reconstruction/MVAUtils

    Adding @goetz ,@turra as watchers

  • Yuan-Tang Chou resolved all threads

    resolved all threads

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash c5cabe3f)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42307]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash c5cabe3f)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 3
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8381]

  • Ruggero Turra
  • Ruggero Turra
  • Removing the L1 review label until internal discussions are solved. Feel free to put it back once all discussions are resolved (will be put back by the CI in case there are new commits).

    I also saw some warnings in the CI but I don't think they are related to this MR.

    Kira (L1)

  • Yuan-Tang Chou added 2 commits

    added 2 commits

    • 99917f2b - Change to better understanding splitting condition
    • 3334a0a2 - Add XGBoost unit test modules

    Compare with previous version

  • This merge request affects 1 package:

    • Reconstruction/MVAUtils

    Adding @goetz ,@turra as watchers

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 3334a0a2)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8522]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash 3334a0a2)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42348]

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • Hi, I would like to pass it to L2 shifter in order to double check the new full files that have been added.

    Thanks, Mazuza (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading