21.2 improved leakage for photon iso

An updated photon isolation leakage parameterisation has been provided. The code has been modified to be able to switch between the updated and default one. Both parameterisations come from rel20.2 studies, and the same input histograms, therefore the name of the calibration root file sill contains rel20_2 as the default one. The default is to use the previous parameterisation, but at analysis level, once the new data-driven correction will be available, the recommendation will be to use the update parameterisation

added 21.2 Analysis Derivation Egamma Recommendation labels

added 1 commit

• ea4546ba - correction file name

Compare with previous version

Hi @jdevivi, may I ask when you plan to resolve WIP status on this MR?

added 1 commit

• 33622fb3 - new leakage file location

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

added review-pending-level-1 label

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 33622fb3)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 1, warnings 18
For experts only: Jenkins output [CI-MERGE-REQUEST 42658]

marked as a Work In Progress

put WIP again as I do not know how to make the test compile within AthDerivation yet

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 33622fb3)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 136
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9538]

removed review-pending-level-1 label

Removing review label for now as this MR is still a WIP...

Magdalena (L1 shifter)

added 1 commit

• 971fdd18 - do not try to compile the real test in AthDerivation

Compare with previous version

unmarked as a Work In Progress

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

added review-pending-level-1 label

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 971fdd18)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9548]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 971fdd18)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42659]

resolved all threads

CI looks good. I'm happy to approve. Clara (L1)

(Copyright in last file wasn't updated, but I decided not to hold up the MR, if you touch the file again, please update it )

added review-approved label and removed review-pending-level-1 label

Hi @krumnack,

Could you please have a look at this MR? Looks mostly like changes in PhysicsAnalysis.

Thanks, Oana

Overall this seems Ok, apart from how the tests were added to the CMakeLists.txt file, which should be fixed before this can go in. Same for using ATLAS message streams instead of std::cout.

Not as something for you to fix, but it seems that most of the tool code you changed is a very long tedious list variable assignments. This is less than ideal, as it is very hard and tedious for people to parse. If there is a typo/mistake in there anywhere, I'm not sure anybody would catch that without looking at the output of the tool…

added review-user-action-required label and removed review-approved label

Hi @cnellist,

For merge requests that are this extensive, please mark it for further review and don't just approve it at level 1.

Regards, Nils

added 1 commit

• 73cdf597 - remove cout, mem executable as test

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

added review-pending-level-1 label and removed review-user-action-required label

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 73cdf597)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9732]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 73cdf597)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42699]

Both requests from @krumnack have been addressed, I'll leave it to him for resolving the discussion and merging.

AR Shifter

added RC Attention Required label and removed review-pending-level-1 label

added review-pending-expert label

resolved all threads

added review-approved label and removed RC Attention Required review-pending-expert labels

added review-user-action-required label and removed review-approved label

added 1 commit

• 9e7793c7 - virtual inheritance for IIsolationCorrectionTool

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/IsolationCorrections

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 9e7793c7)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42715]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 9e7793c7)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9790]

added review-approved label and removed review-pending-level-1 label

This was already approved, and only one minor change was added.

@egramsta, @guirriec, @boeriu: From the AnalysisBase side this is Ok. Please check if/how this affects derivations and then merge it.

merged

mentioned in commit 836cb74c

added sweep:ignore label