Make ISimulatorTools private

Currently the ISimulatorTools used in the ISF are public tools in both jobs using the old style SimKernel and jobs using the MT-compatible SimKernelMT. This merge request makes the ToolHandleArray<ISimulatorTool> owned by SimKernelMT private. This has the side effect of changing the random number seeds used in these tools (as the seeding was based on the tool names). In order to mitigate this effect, the random number streams used by the tools are now seeded using a configurable stream name rather than the name of the tool.

added Run2-FullSim-output-changed label

This should be merged after !29832 (merged). Possibly should merge the random number stream changes separately. FYI @bwynne and @mbandier.

added 3 commits

• d08c2c59 - Remove unused ISimulatorTool::push method
• 50b6f056 - Use a fixed StreamName for the random number service in ISimulatorTool implementations
• 5a958734 - Make SimKernelMT ISimulatorTool ToolHandleArray private

Compare with previous version

added 1 commit

• 49d9300b - Make SimKernelMT ISimulatorTool ToolHandleArray private

Compare with previous version

added 116 commits

• 49d9300b...305a985c - 114 commits from branch atlas:master
• f0dfa3d8 - Use a fixed StreamName for the random number service in ISimulatorTool implementations
• 857f83eb - Make SimKernelMT ISimulatorTool ToolHandleArray private

Compare with previous version

mentioned in merge request !29913 (merged)

added 160 commits

• 857f83eb...fdb8d27c - 159 commits from branch atlas:master
• 921901d0 - Make SimKernelMT ISimulatorTool ToolHandleArray private

Compare with previous version

removed Run2-FullSim-output-changed label

unmarked as a Work In Progress

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Algorithms

Adding @jchapman ,@vpascuzz as watchers

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash 921901d0)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8953]

CI fine, changes are clear, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ae3eb80b

added sweep:ignore label