Move from MuonIdHelperTool to MuonIdHelperSvc (6)

Hi,

this MR uses MuonIdHelperSvc instead of MuonIdHelperTool in several muon packages. Furthermore, some cleanup is done (e.g. using ATH_CHECK macros where possible, removing unused includes, deleting commented code lines, ...).

Best, Nico

mentioned in merge request !28546 (closed)

This merge request affects 9 packages:

• MuonSpectrometer/MuonCalib/MuonCalibAlgs
• MuonSpectrometer/MuonCalib/MuonCalibDbOperations
• MuonSpectrometer/MuonCalib/MuonCalibExtraTree/MuonCalibExtraTreeAlg
• MuonSpectrometer/MuonCalib/MuonCalibPatRec
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/CalibNtupleAnalysisAlg
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/MdtCalibIOSvc
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/MuonCalibStandAloneBase
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/MuonCalibStandAloneExtraTools
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/MuonCalibStandAloneTools

Adding @rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS (hash bc1d4cc7)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8971]

Code changes look fine, approving.

Magdalena (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit f003a430

added sweep:ignore label