Skip to content
Snippets Groups Projects

Adding new option in TileCellSelector - either low or high gain channels can be selected

Merged Sanya Solodkov requested to merge solodkov/athena:tilecal-for-21.0 into 21.0

TileCellSelector is used in TileCal private jobs to select events with desired properties before they are reconstructed. One more option has been added to select only events with at least one TileCal channel in low gain.

Merge request reports

Checking pipeline status.

Merged by Ruth PottgenRuth Pottgen 4 years ago (Feb 7, 2020 1:24pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I reviewd the code, it looks fine. Just one small issue above.

    Roman (L1)

  • Sanya Solodkov added 1 commit

    added 1 commit

    Compare with previous version

  • Sanya Solodkov resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • TileCalorimeter/TileRecAlgs

    Adding @pavol ,@solodkov ,@harkusha as watchers

  • :white_check_mark: CI Result SUCCESS (hash c5759bae)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthDataQuality: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42578]

  • Looks good, approving

  • merged

  • Ruth Pottgen mentioned in commit 635e7def

    mentioned in commit 635e7def

  • Sweep summary
    failed:

    • master
  • Sanya Solodkov mentioned in merge request !30398 (merged)

    mentioned in merge request !30398 (merged)

  • Author Developer

    manual merge to master, see !30398 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading