Skip to content
Snippets Groups Projects

Add new package CaloSamplingFractionAnalysis for calorimeter sampling fraction extraction

This is a new package to collect code from LAr EM, Tile, HEC and FCal for the calculation of the sampling fractions. The aim is to have the code running ~automatic in the end for new versions of G4 or new physics lists.

Edited by Michael Duehrssen-Debling

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • In general it looks fine to me, but I would like to have it reviewed by L2 as well. In the meantime, it would be good to remove unnecessary commented lines and white space. Cheers, Clara (L1)

  • added 1 commit

    • 482c774a - CaloSamplingFractionAnalysis: implement feedback to MR 30345

    Compare with previous version

  • resolved all threads

  • This merge request affects 1 package:

    • Simulation/Tools/CaloSamplingFractionAnalysis

    Adding @jchapman ,@vpascuzz as watchers

  • :white_check_mark: CI Result SUCCESS (hash 482c774a)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :warning: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 158
    :warning: AthDataQuality: number of compilation errors 0, warnings 1
    :warning: AthSimulation: number of compilation errors 0, warnings 5
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 42692]

  • All L1 review ppoints have been addressed passing on to L2 for further review.

    Kira (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading